Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2042873002: Revert of [stubs] Enable TurboFan LoadIC dispatcher stub. (Closed)

Created:
4 years, 6 months ago by adamk
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@load-ic-stub-tf
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [stubs] Enable TurboFan LoadIC dispatcher stub. (patchset #1 id:1 of https://codereview.chromium.org/2033943005/ ) Reason for revert: Fails cctest consistently on Linux nosnap debug: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/7185 https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/7186 https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/7187 Original issue's description: > [stubs] Enable TurboFan LoadIC dispatcher stub. > > Committed: https://crrev.com/46a9322e88de037598cfd1090285375d97b11db2 > Cr-Commit-Position: refs/heads/master@{#36760} TBR=verwaest@chromium.org,ishell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/59785f9e644e934f48f831dd3c0cd9ea431c1166 Cr-Commit-Position: refs/heads/master@{#36764}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
adamk
Created Revert of [stubs] Enable TurboFan LoadIC dispatcher stub.
4 years, 6 months ago (2016-06-06 19:06:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042873002/1
4 years, 6 months ago (2016-06-06 19:06:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 19:07:06 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 19:10:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59785f9e644e934f48f831dd3c0cd9ea431c1166
Cr-Commit-Position: refs/heads/master@{#36764}

Powered by Google App Engine
This is Rietveld 408576698