Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2042863002: Set the Accept-Language header in Physical Web requests (Closed)

Created:
4 years, 6 months ago by mattreynolds
Modified:
4 years, 6 months ago
Reviewers:
Olivier
CC:
chromium-reviews, sdefresne+watch_chromium.org, mmocny
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set the Accept-Language header in Physical Web requests The Physical Web service now supports locale-specific metadata caching. To receive metadata specific to the user's locale, attach the language code for the current system locale to the metadata request. BUG=607660 Committed: https://crrev.com/b6c861975caa530967100d68329e1d7cb520c194 Cr-Commit-Position: refs/heads/master@{#399140}

Patch Set 1 #

Total comments: 2

Patch Set 2 : re-add logging include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M ios/chrome/common/physical_web/physical_web_request.mm View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
mattreynolds
Hi Olivier, PTAL
4 years, 6 months ago (2016-06-08 19:23:38 UTC) #2
Olivier
https://codereview.chromium.org/2042863002/diff/1/ios/chrome/common/physical_web/physical_web_request.mm File ios/chrome/common/physical_web/physical_web_request.mm (right): https://codereview.chromium.org/2042863002/diff/1/ios/chrome/common/physical_web/physical_web_request.mm#newcode71 ios/chrome/common/physical_web/physical_web_request.mm:71: NOTREACHED(); This is defined int base/logging. Please let the ...
4 years, 6 months ago (2016-06-09 07:47:31 UTC) #3
mattreynolds
https://codereview.chromium.org/2042863002/diff/1/ios/chrome/common/physical_web/physical_web_request.mm File ios/chrome/common/physical_web/physical_web_request.mm (right): https://codereview.chromium.org/2042863002/diff/1/ios/chrome/common/physical_web/physical_web_request.mm#newcode71 ios/chrome/common/physical_web/physical_web_request.mm:71: NOTREACHED(); On 2016/06/09 07:47:31, Olivier Robin wrote: > This ...
4 years, 6 months ago (2016-06-09 19:43:57 UTC) #4
Olivier
lgtm
4 years, 6 months ago (2016-06-10 08:37:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042863002/20001
4 years, 6 months ago (2016-06-10 08:38:01 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-10 09:13:39 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 09:15:52 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b6c861975caa530967100d68329e1d7cb520c194
Cr-Commit-Position: refs/heads/master@{#399140}

Powered by Google App Engine
This is Rietveld 408576698