xfa_fm2jscontext method cleanup - pt V

xfa_fm2jscontext method cleanup - pt V

Cleans up ::Oneof, ::HasValue, ::Exists, ::Choose, ::Term, ::Rate, ::PV, ::PPmt,
::Pmt, ::NPV, ::IPmt, ::FV, ::CTerm and ::Apr

Committed: https://pdfium.googlesource.com/pdfium/+/96a05f40eca8c5e717e38b050997ff6248842e21

[dsinclair, 2016-06-06 21:04:06]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-06-06 21:04:07]

PTAL.

https://codereview.chromium.org/2042843003/diff/1/xfa/fxfa/fm2js/xfa_fm2jscon...
File xfa/fxfa/fm2js/xfa_fm2jscontext.cpp (right):

https://codereview.chromium.org/2042843003/diff/1/xfa/fxfa/fm2js/xfa_fm2jscon...
xfa/fxfa/fm2js/xfa_fm2jscontext.cpp:2604: std::vector<FX_DOUBLE> data;
Converted this to a vector.

[dsinclair, 2016-06-06 21:04:07]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-06-06 21:04:07]

PTAL.

[Tom Sepez, 2016-06-06 21:22:59]

lgtm

https://codereview.chromium.org/2042843003/diff/1/xfa/fxfa/fm2js/xfa_fm2jscon...
File xfa/fxfa/fm2js/xfa_fm2jscontext.cpp (right):

https://codereview.chromium.org/2042843003/diff/1/xfa/fxfa/fm2js/xfa_fm2jscon...
xfa/fxfa/fm2js/xfa_fm2jscontext.cpp:2604: std::vector<FX_DOUBLE> data;
probably want data(argc - 1) ctor to reserve all the space at once.

https://codereview.chromium.org/2042843003/diff/1/xfa/fxfa/fm2js/xfa_fm2jscon...
xfa/fxfa/fm2js/xfa_fm2jscontext.cpp:2922: } else {
nit; maybe early return instead of else.

[dsinclair, 2016-06-07 13:37:59]

https://codereview.chromium.org/2042843003/diff/1/xfa/fxfa/fm2js/xfa_fm2jscon...
File xfa/fxfa/fm2js/xfa_fm2jscontext.cpp (right):

https://codereview.chromium.org/2042843003/diff/1/xfa/fxfa/fm2js/xfa_fm2jscon...
xfa/fxfa/fm2js/xfa_fm2jscontext.cpp:2604: std::vector<FX_DOUBLE> data;
On 2016/06/06 21:22:59, Tom Sepez wrote:
> probably want data(argc - 1) ctor to reserve all the space at once.

Done.

https://codereview.chromium.org/2042843003/diff/1/xfa/fxfa/fm2js/xfa_fm2jscon...
xfa/fxfa/fm2js/xfa_fm2jscontext.cpp:2922: } else {
On 2016/06/06 21:22:59, Tom Sepez wrote:
> nit; maybe early return instead of else.

Done.

[dsinclair, 2016-06-07 13:39:15]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-06-07 13:39:16]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2042843003/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-06-07 13:39:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2042843003/40001

[commit-bot: I haz the power, 2016-06-07 13:48:05]

Description was changed from

==========
xfa_fm2jscontext method cleanup - pt V

Cleans up ::Oneof, ::HasValue, ::Exists, ::Choose, ::Term, ::Rate, ::PV, ::PPmt,
::Pmt, ::NPV, ::IPmt, ::FV, ::CTerm and ::Apr
==========

to

==========
xfa_fm2jscontext method cleanup - pt V

Cleans up ::Oneof, ::HasValue, ::Exists, ::Choose, ::Term, ::Rate, ::PV, ::PPmt,
::Pmt, ::NPV, ::IPmt, ::FV, ::CTerm and ::Apr

Committed:
https://pdfium.googlesource.com/pdfium/+/96a05f40eca8c5e717e38b050997ff624884...
==========

[commit-bot: I haz the power, 2016-06-07 13:48:06]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/96a05f40eca8c5e717e38b050997ff624884...