Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2042773002: [wasm] Move 64-bit call tests into test-run-wasm-64.cc so they also run on 32-bit platforms. (Closed)

Created:
4 years, 6 months ago by titzer
Modified:
4 years, 6 months ago
Reviewers:
ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Move 64-bit call tests into test-run-wasm-64.cc so they also run on 32-bit platforms. This duplicates some test code (which hopefully can be factored out later), but increases test coverage. R=ahaas@chromium.org BUG= Committed: https://crrev.com/585771f26421080afe1d63e560a0e4d0155d1d37 Cr-Commit-Position: refs/heads/master@{#36739}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -29 lines) Patch
M test/cctest/wasm/test-run-wasm.cc View 4 chunks +3 lines, -22 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 2 chunks +157 lines, -0 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
4 years, 6 months ago (2016-06-06 09:40:03 UTC) #1
ahaas
lgtm
4 years, 6 months ago (2016-06-06 09:45:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042773002/1
4 years, 6 months ago (2016-06-06 10:56:53 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 10:58:53 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 10:59:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/585771f26421080afe1d63e560a0e4d0155d1d37
Cr-Commit-Position: refs/heads/master@{#36739}

Powered by Google App Engine
This is Rietveld 408576698