third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-div-scrollable-but-without-focusable-content.html - Issue 2042763002: Fix re-usage of stale cached WebPreferences in RenderViewHost.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-div-scrollable-but-without-focusable-content.html

Issue 2042763002: Fix re-usage of stale cached WebPreferences in RenderViewHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-div-overflow-scrol-hidden.html ('k') | third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-fully-aligned-horizontally.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <!--	2 <!--

3 This test ensures the correctness of a basic aspect of spatial navigation tr aversal	3 This test ensures the correctness of a basic aspect of spatial navigation tr aversal

4 routines: scrollable block html elements without any focusable content shoul d be ignored.	4 routines: scrollable block html elements without any focusable content shoul d be ignored.

5	5

6 * Pre-conditions:	6 * Pre-conditions:

7 1) DRT support for spatial navigation enable/disable.	7 1) DRT support for spatial navigation enable/disable.

8	8

9 * Navigation steps:	9 * Navigation steps:

10 1) Loads this page, focus goes to "start" automatically.	10 1) Loads this page, focus goes to "start" automatically.

(...skipping 30 matching lines...) Expand all Loading...
41 ["Up" , "end"],	41 ["Up" , "end"],

42 ["Up" , "end"],	42 ["Up" , "end"],

43 ["Up" , "end"],	43 ["Up" , "end"],

44 ["Up" , "start"],	44 ["Up" , "start"],

45 ["DONE", "DONE"]	45 ["DONE", "DONE"]

46 ];	46 ];

47	47

48 if (window.testRunner) {	48 if (window.testRunner) {

49 testRunner.dumpAsText();	49 testRunner.dumpAsText();

50 testRunner.overridePreference("WebKitTabToLinksPreferenceKey", 1);	50 testRunner.overridePreference("WebKitTabToLinksPreferenceKey", 1);

51 window.internals.settings.setSpatialNavigationEnabled(true);	51 testRunner.overridePreference("WebKitSpatialNavigationEnabled", 1);

52 testRunner.waitUntilDone();	52 testRunner.waitUntilDone();

53 }	53 }

54	54

55 function runTest()	55 function runTest()

56 {	56 {

57 // starting the test itself: get to a known place.	57 // starting the test itself: get to a known place.

58 document.getElementById("start").focus();	58 document.getElementById("start").focus();

59	59

60 initTest(resultMap, testCompleted);	60 initTest(resultMap, testCompleted);

61 }	61 }

(...skipping 14 matching lines...) Expand all Loading...
76 </div>	76 </div>

77	77

78 <div class="scroll">	78 <div class="scroll">

79 <img src="resources/green.png" width=240 height=300>	79 <img src="resources/green.png" width=240 height=300>

80 </div>	80 </div>

81 <div><a id="end" href="a"><img src="resources/green.png" width=30 height=30> </a></div>	81 <div><a id="end" href="a"><img src="resources/green.png" width=30 height=30> </a></div>

82 <div id="console"></div>	82 <div id="console"></div>

83 This test is to test that a scrollable div can scroll and reveal its content even if it does not have any focusable content.	83 This test is to test that a scrollable div can scroll and reveal its content even if it does not have any focusable content.

84 </body>	84 </body>

85 </html>	85 </html>

OLD	NEW