cc/trees/layer_tree_host_unittest_animation.cc - Issue 2042713002: CC Animation: Activate/deactivate ElementAnimations on Layer addition/removal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host_unittest_animation.cc

Issue 2042713002: CC Animation: Activate/deactivate ElementAnimations on Layer addition/removal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix the nit. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/trees/layer_tree_host_unittest_animation.cc

diff --git a/cc/trees/layer_tree_host_unittest_animation.cc b/cc/trees/layer_tree_host_unittest_animation.cc

index b03ae9ab6310436b466a5dd47c6e06904cec8091..ebf1854bddb7a384999a528f51b633d94d9f088b 100644

--- a/cc/trees/layer_tree_host_unittest_animation.cc

+++ b/cc/trees/layer_tree_host_unittest_animation.cc

@@ -1250,7 +1250,7 @@ class LayerTreeHostAnimationTestAnimatedLayerRemovedAndAdded

player_->element_animations()->has_element_in_active_list());

EXPECT_FALSE(

player_->element_animations()->has_element_in_pending_list());

- EXPECT_TRUE(layer_tree_host()->animation_host()->NeedsAnimateLayers());

+ EXPECT_FALSE(layer_tree_host()->animation_host()->NeedsAnimateLayers());

break;

case 2:

layer_tree_host()->root_layer()->AddChild(layer_);

@@ -1278,7 +1278,7 @@ class LayerTreeHostAnimationTestAnimatedLayerRemovedAndAdded

case 1:

EXPECT_FALSE(

player_impl->element_animations()->has_element_in_active_list());

- EXPECT_TRUE(host_impl->animation_host()->NeedsAnimateLayers());

+ EXPECT_FALSE(host_impl->animation_host()->NeedsAnimateLayers());

break;

case 2:

EXPECT_TRUE(

« no previous file with comments | « cc/trees/layer_tree_host_impl_unittest.cc ('k') | no next file » | no next file with comments »