Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/paint/SVGImagePainter.cpp

Issue 2042703002: Handle 'visibility:collapse' for SVG shapes/images/text-decorations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed resource file Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/LayoutTests/svg/custom/visibility-collapse.html ('K') | « third_party/WebKit/LayoutTests/svg/custom/visibility-collapse-expected.html ('k') | third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/SVGImagePainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/SVGImagePainter.cpp b/third_party/WebKit/Source/core/paint/SVGImagePainter.cpp
index 232c9f517e6e2f5f720a29e0a47cb21e042bc376..7dc34c714c750fa430c2d8d5c773fa207adb6c43 100644
--- a/third_party/WebKit/Source/core/paint/SVGImagePainter.cpp
+++ b/third_party/WebKit/Source/core/paint/SVGImagePainter.cpp
@@ -24,6 +24,7 @@ void SVGImagePainter::paint(const PaintInfo& paintInfo)
{
if (paintInfo.phase != PaintPhaseForeground
|| m_layoutSVGImage.style()->visibility() == HIDDEN
pdr. 2016/06/07 23:02:25 We should just check for "visibility() != VISIBLE"
Shanmuga Pandi 2016/06/08 05:17:13 Done.
+ || m_layoutSVGImage.style()->visibility() == COLLAPSE
|| !m_layoutSVGImage.imageResource()->hasImage())
return;
« third_party/WebKit/LayoutTests/svg/custom/visibility-collapse.html ('K') | « third_party/WebKit/LayoutTests/svg/custom/visibility-collapse-expected.html ('k') | third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698