Implement cc::CompositorFrameMetadata StructTraits

Implement cc::CompositorFrameMetadata StructTraits

This CL replaces the simple mus CompositorFrameMetadata struct with a
full fidelity struct along with StructTraits. w00t! Soon full fidelity
CompositorFrames in Mus without extra copies!

BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/10bec68301c42372e7b1d31a53150462baaae1d9
Cr-Commit-Position: refs/heads/master@{#398222}

[Fady Samuel, 2016-06-05 21:48:48]

Description was changed from

==========
Implement cc::CompositorFrameMetadata StructTraits

This CL replaces the simple mus CompositorFrameMetadata struct with a
full fidelity struct along with StructTraits. w00t! Soon full fidelity
CompositorFrames in Mus without extra copies!

BUG=611802
==========

to

==========
Implement cc::CompositorFrameMetadata StructTraits

This CL replaces the simple mus CompositorFrameMetadata struct with a
full fidelity struct along with StructTraits. w00t! Soon full fidelity
CompositorFrames in Mus without extra copies!

BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Fady Samuel, 2016-06-05 21:51:49]

fsamuel@chromium.org changed reviewers:
+ ben@chromium.org, piman@chromium.org, tsepez@chromium.org, yzshen@chromium.org

[Fady Samuel, 2016-06-05 21:51:50]

+piman@ for cc/ OWNER
+tsepez@ for ipc security
+yzshen@ for Struct Traits feedback
+ben@ for mus + bitmap_uploader

[Fady Samuel, 2016-06-05 21:52:37]

Please note that this CL is diff'ed against my LatencyInfo StructTraits CL:
https://codereview.chromium.org/2040733002/

Thanks!

[Tom Sepez, 2016-06-06 16:17:55]

mojom lgtm

[yzshen1, 2016-06-06 16:22:04]

https://codereview.chromium.org/2042643002/diff/20001/cc/ipc/compositor_frame...
File cc/ipc/compositor_frame_metadata_struct_traits.h (right):

https://codereview.chromium.org/2042643002/diff/20001/cc/ipc/compositor_frame...
cc/ipc/compositor_frame_metadata_struct_traits.h:21: static gfx::Vector2dF
root_scroll_offset(
Does it make sense to return a ref instead?

https://codereview.chromium.org/2042643002/diff/20001/components/bitmap_uploa...
File components/bitmap_uploader/bitmap_uploader.cc (right):

https://codereview.chromium.org/2042643002/diff/20001/components/bitmap_uploa...
components/bitmap_uploader/bitmap_uploader.cc:78: cc::CompositorFrameMetadata
meta;
this variable is not used anymroe.

[Ben Goodger (Google), 2016-06-06 18:15:26]

mus/bitmap_uploader lgtm

[piman, 2016-06-06 19:50:46]

lgtm

[Fady Samuel, 2016-06-06 20:00:11]

PTAL Yuzhu! Thanks

https://codereview.chromium.org/2042643002/diff/20001/cc/ipc/compositor_frame...
File cc/ipc/compositor_frame_metadata_struct_traits.h (right):

https://codereview.chromium.org/2042643002/diff/20001/cc/ipc/compositor_frame...
cc/ipc/compositor_frame_metadata_struct_traits.h:21: static gfx::Vector2dF
root_scroll_offset(
On 2016/06/06 16:22:04, yzshen1 wrote:
> Does it make sense to return a ref instead?

I'll stick to return by value because Vector2dF is only two floats.

https://codereview.chromium.org/2042643002/diff/20001/components/bitmap_uploa...
File components/bitmap_uploader/bitmap_uploader.cc (right):

https://codereview.chromium.org/2042643002/diff/20001/components/bitmap_uploa...
components/bitmap_uploader/bitmap_uploader.cc:78: cc::CompositorFrameMetadata
meta;
On 2016/06/06 16:22:04, yzshen1 wrote:
> this variable is not used anymroe.

Done.

[yzshen1, 2016-06-06 20:01:08]

lgtm

[Fady Samuel, 2016-06-07 03:01:12]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-06-07 03:01:13]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
ben@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2042643002/#ps40001
(title: "Addressed comment")

[commit-bot: I haz the power, 2016-06-07 03:01:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2042643002/40001

[commit-bot: I haz the power, 2016-06-07 04:25:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-07 04:27:05]

Description was changed from

==========
Implement cc::CompositorFrameMetadata StructTraits

This CL replaces the simple mus CompositorFrameMetadata struct with a
full fidelity struct along with StructTraits. w00t! Soon full fidelity
CompositorFrames in Mus without extra copies!

BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Implement cc::CompositorFrameMetadata StructTraits

This CL replaces the simple mus CompositorFrameMetadata struct with a
full fidelity struct along with StructTraits. w00t! Soon full fidelity
CompositorFrames in Mus without extra copies!

BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/10bec68301c42372e7b1d31a53150462baaae1d9
Cr-Commit-Position: refs/heads/master@{#398222}
==========

[commit-bot: I haz the power, 2016-06-07 04:27:06]

Patchset 3 (id:??) landed as
https://crrev.com/10bec68301c42372e7b1d31a53150462baaae1d9
Cr-Commit-Position: refs/heads/master@{#398222}