src/interpreter/bytecode-peephole-optimizer.h - Issue 2042633002: [interpreter] Ensure optimizations preserve source positions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecode-peephole-optimizer.h

Issue 2042633002: [interpreter] Ensure optimizations preserve source positions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Incorporate review comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/interpreter/bytecode-peephole-optimizer.h

diff --git a/src/interpreter/bytecode-peephole-optimizer.h b/src/interpreter/bytecode-peephole-optimizer.h

index 22e47030ac234badb0b3aaf8579244de5c103f77..e6ada2aa1ef244c4f3c07c176f80ac26df4994ca 100644

--- a/src/interpreter/bytecode-peephole-optimizer.h

+++ b/src/interpreter/bytecode-peephole-optimizer.h

@@ -37,6 +37,7 @@ class BytecodePeepholeOptimizer final : public BytecodePipelineStage,

void Flush();

void TryToRemoveLastExpressionPosition(const BytecodeNode* const current);

+ bool TransformCurrentBytecode(BytecodeNode* const current);

bool TransformLastAndCurrentBytecodes(BytecodeNode* const current);

bool CanElideCurrent(const BytecodeNode* const current) const;

bool CanElideLast(const BytecodeNode* const current) const;

@@ -46,7 +47,6 @@ class BytecodePeepholeOptimizer final : public BytecodePipelineStage,

// Simple substitution methods.

bool RemoveToBooleanFromJump(BytecodeNode* const current);

bool RemoveToBooleanFromLogicalNot(BytecodeNode* const current);

- bool ChangeLdaToLdr(BytecodeNode* const current);

void InvalidateLast();

bool LastIsValid() const;

« no previous file with comments | « no previous file | src/interpreter/bytecode-peephole-optimizer.cc » ('j') | test/cctest/interpreter/bytecode_expectations/PropertyLoads.golden » ('J')