[interpreter] Ensure optimizations preserve source positions.

src/interpreter/bytecodes.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/bytecodes.h"
 
 #include <iomanip>
 
 #include "src/frames.h"
 #include "src/interpreter/bytecode-traits.h"
@@ skipping 258 matching lines @@
     case Bytecode::kLdaTrue:
     case Bytecode::kLdaFalse:
     case Bytecode::kLdaConstant:
     case Bytecode::kLdar:
       return true;
     default:
       return false;
   }
 }
 
+bool Bytecodes::IsJumpWithoutEffects(Bytecode bytecode) {

[rmcilroy, 2016/06/08 11:31:40]

// static

[oth, 2016/06/08 14:18:25]

Done.

+  return IsJump(bytecode) && !IsJumpIfToBoolean(bytecode);
+}
+

[rmcilroy, 2016/06/08 11:31:40]

// static

[oth, 2016/06/08 14:18:25]

Done.

+bool Bytecodes::IsRegisterLoadWithoutEffects(Bytecode bytecode) {
+  switch (bytecode) {
+    case Bytecode::kMov:
+    case Bytecode::kPopContext:
+    case Bytecode::kPushContext:
+    case Bytecode::kStar:
+    case Bytecode::kLdrUndefined:
+      return true;
+    default:
+      return false;
+  }
+}
+
+// static
+bool Bytecodes::IsWithoutExternalSideEffects(Bytecode bytecode) {
+  // These bytecodes only manipulate interpreter frame state and will
+  // never throw.
+  return (IsAccumulatorLoadWithoutEffects(bytecode) ||
+          IsRegisterLoadWithoutEffects(bytecode) ||
+          bytecode == Bytecode::kNop || IsJumpWithoutEffects(bytecode));
+}
+
 // static
 OperandType Bytecodes::GetOperandType(Bytecode bytecode, int i) {
   DCHECK_LE(bytecode, Bytecode::kLast);
   DCHECK_LT(i, NumberOfOperands(bytecode));
   DCHECK_GE(i, 0);
   return GetOperandTypes(bytecode)[i];
 }
 
 // static
 const OperandType* Bytecodes::GetOperandTypes(Bytecode bytecode) {
@@ skipping 192 matching lines @@
     case Bytecode::kDebugBreakExtraWide:
     case Bytecode::kWide:
     case Bytecode::kDebugBreakWide:
       return true;
     default:
       return false;
   }
 }
 
 // static
-bool Bytecodes::IsWithoutExternalSideEffects(Bytecode bytecode) {
-  // These bytecodes only manipulate interpreter frame state and will
-  // never throw.
-  return (IsAccumulatorLoadWithoutEffects(bytecode) || IsLdarOrStar(bytecode) ||
-          bytecode == Bytecode::kMov || bytecode == Bytecode::kNop ||
-          IsJump(bytecode));
-}
-
-// static
 bool Bytecodes::IsJumpOrReturn(Bytecode bytecode) {
   return bytecode == Bytecode::kReturn || IsJump(bytecode);
 }
 
 // static
 bool Bytecodes::IsMaybeRegisterOperandType(OperandType operand_type) {
   return operand_type == OperandType::kMaybeReg;
 }
 
 // static
@@ skipping 462 matching lines @@
   } else {
     std::ostringstream s;
     s << "r" << index();
     return s.str();
   }
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8