third_party/WebKit/Source/core/layout/LayoutObject.cpp - Issue 2042623002: Mark container chain of out-of-flow objects for layout correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2042623002: Mark container chain of out-of-flow objects for layout correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/block/positioning/mark-layout-on-chain-of-pos-objects-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

index 21674ddb9d57c40e1c00c5885e795195c1cc6518..1fa8d3b8741331f6f96ab3cf6b45408da69ad2b9 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

@@ -769,11 +769,11 @@ void LayoutObject::markContainerChainForLayout(bool scheduleRelayout, SubtreeLay

if (!container && !object->isLayoutView())

return;

if (!last->isTextOrSVGChild() && last->style()->hasOutOfFlowPosition()) {

- LayoutBlock* containingBlock = last->containingBlock();

- if (containingBlock->posChildNeedsLayout())

+ object = last->containingBlock();

+ if (object->posChildNeedsLayout())

return;

- container = containingBlock->container();

- containingBlock->setPosChildNeedsLayout(true);

+ container = object->container();

+ object->setPosChildNeedsLayout(true);

simplifiedNormalFlowLayout = true;

ASSERT(!object->isSetNeedsLayoutForbidden());

} else if (simplifiedNormalFlowLayout) {

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/block/positioning/mark-layout-on-chain-of-pos-objects-expected.html ('k') | no next file » | no next file with comments »