Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2042613002: Convert track-webvtt-tc[006,007,011] tests to testharness.js (Closed)

Created:
4 years, 6 months ago by Srirama
Modified:
4 years, 6 months ago
Reviewers:
fs, foolip
CC:
fs, blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, gasubic, mlamouri+watch-blink_chromium.org, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert track-webvtt-tc[006,007,011] tests to testharness.js Cleaning up track-webvtt-tc[006,007,011] tests in media/track to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. Updated track-webvtt-tc006-cue-identifiers.html and track-webvtt-tc007-cue-no-id.html to reflect that "-->" is now allowed in cue identifiers. Updated track-webvtt-tc011-blank-lines.html to reflect that a timing line always starts a new cue in absence of a separating line. BUG=588956 Committed: https://crrev.com/b4e200f61f06f94474979d4d2733c30a02785360 Cr-Commit-Position: refs/heads/master@{#397954}

Patch Set 1 : #

Total comments: 8

Patch Set 2 : address nit and add more info in the description #

Messages

Total messages: 15 (9 generated)
Srirama
PTAL
4 years, 6 months ago (2016-06-05 09:11:10 UTC) #4
fs
LGTM w/ nit, and requests to mention some things in the description. https://codereview.chromium.org/2042613002/diff/2/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc006-cue-identifiers-expected.txt File third_party/WebKit/LayoutTests/media/track/track-webvtt-tc006-cue-identifiers-expected.txt ...
4 years, 6 months ago (2016-06-05 13:04:58 UTC) #5
Srirama
https://codereview.chromium.org/2042613002/diff/2/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc006-cue-identifiers-expected.txt File third_party/WebKit/LayoutTests/media/track/track-webvtt-tc006-cue-identifiers-expected.txt (left): https://codereview.chromium.org/2042613002/diff/2/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc006-cue-identifiers-expected.txt#oldcode24 third_party/WebKit/LayoutTests/media/track/track-webvtt-tc006-cue-identifiers-expected.txt:24: EXPECTED (cues.length == '0'), OBSERVED '3' FAIL On 2016/06/05 ...
4 years, 6 months ago (2016-06-05 21:12:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042613002/30001
4 years, 6 months ago (2016-06-05 21:13:01 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:30001)
4 years, 6 months ago (2016-06-05 23:48:04 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-05 23:50:03 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b4e200f61f06f94474979d4d2733c30a02785360
Cr-Commit-Position: refs/heads/master@{#397954}

Powered by Google App Engine
This is Rietveld 408576698