src/effects/SkMagnifierImageFilter.cpp - Issue 20426002: Implement crop rect for lighting image filters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkMagnifierImageFilter.cpp

Issue 20426002: Implement crop rect for lighting image filters. (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Bugfix: set the bitmap's width and height to the bounds's width and height, Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkMagnifierImageFilter.cpp

diff --git a/src/effects/SkMagnifierImageFilter.cpp b/src/effects/SkMagnifierImageFilter.cpp

index a68ab7cc967c5c41b0996fe15e921007e9456115..f4a72b8d2c0ebeedf9b5959ad23491b8eb27ce82 100644

--- a/src/effects/SkMagnifierImageFilter.cpp

+++ b/src/effects/SkMagnifierImageFilter.cpp

@@ -218,7 +218,7 @@ GrEffectRef* GrMagnifierEffect::TestCreate(SkMWCRandom* random,

SkIntToScalar(width), SkIntToScalar(height)),

inset));

GrEffectRef* effect;

- filter->asNewEffect(&effect, textures[0]);

+ filter->asNewEffect(&effect, textures[0], SkIPoint::Make(0, 0));

GrAssert(NULL != effect);

return effect;

}

@@ -264,7 +264,7 @@ SkMagnifierImageFilter::SkMagnifierImageFilter(SkRect srcRect, SkScalar inset)

}

#if SK_SUPPORT_GPU

-bool SkMagnifierImageFilter::asNewEffect(GrEffectRef** effect, GrTexture* texture) const {

+bool SkMagnifierImageFilter::asNewEffect(GrEffectRef** effect, GrTexture* texture, const SkIPoint&) const {

if (effect) {

*effect = GrMagnifierEffect::Create(texture,

fSrcRect.x() / texture->width(),