include/core/SkImageFilter.h - Issue 20426002: Implement crop rect for lighting image filters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkImageFilter.h

Issue 20426002: Implement crop rect for lighting image filters. (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Bugfix: set the bitmap's width and height to the bounds's width and height, Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/core/SkImageFilter.h

diff --git a/include/core/SkImageFilter.h b/include/core/SkImageFilter.h

index e467761a1f0607e2ce244003be132c295c4f9874..54de2881d561f10fa0642bcae2d91b7d66f80713 100644

--- a/include/core/SkImageFilter.h

+++ b/include/core/SkImageFilter.h

@@ -91,9 +91,10 @@ public:

* caller to unref it.

* The effect can assume its vertexCoords space maps 1-to-1 with texels

- * in the texture.

+ * in the texture. "offset" is the delta between the source and

+ * destination rect's origins, when cropped processing is being performed.

- virtual bool asNewEffect(GrEffectRef** effect, GrTexture*) const;

+ virtual bool asNewEffect(GrEffectRef** effect, GrTexture*, const SkIPoint& offset) const;

/**

* Returns true if the filter can be processed on the GPU. This is most

« no previous file with comments | « gm/lighting.cpp ('k') | include/effects/SkLightingImageFilter.h » ('j') | no next file with comments »