Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2042563002: Fix initialization of AudioTrack related output parameters (Closed)

Created:
4 years, 6 months ago by Tima Vaisburd
Modified:
4 years, 6 months ago
Reviewers:
qinmin, AndyWu
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org, mlamouri+watch-media_chromium.org, yvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix initialization of AudioTrack related output parameters Since AudioCodecBridge::ConfigureAndStart creates AudioTrack instance with config parameters, we need to initialize the output parameters with the same values before we get OnOutputFormatChanged(). Without this step the some changes between config and actual parameters will be undetected, for instance before this change (1) config_num_channels = 2, output_num_channels = 2 old output value was 0, unnecessary AudioTrack recreation (2) config_num_channels = 1, output_num_channels = 2 old output value was 2, no change detected here but AudioTrack was created with num_channels = 1 BUG=none Committed: https://crrev.com/42e063e46ffe17c98d198ebf1e046ad492e159ce Cr-Commit-Position: refs/heads/master@{#398083}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M media/base/android/audio_decoder_job.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M media/base/android/audio_media_codec_decoder.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Tima Vaisburd
Reported and tested by Andy Wu, thank you! PTAL.
4 years, 6 months ago (2016-06-04 00:16:03 UTC) #2
AndyWu
lgtm
4 years, 6 months ago (2016-06-04 00:35:43 UTC) #3
qinmin
lgtm
4 years, 6 months ago (2016-06-06 18:04:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042563002/1
4 years, 6 months ago (2016-06-06 18:08:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 19:12:50 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 19:14:15 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42e063e46ffe17c98d198ebf1e046ad492e159ce
Cr-Commit-Position: refs/heads/master@{#398083}

Powered by Google App Engine
This is Rietveld 408576698