Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 204253002: Do not repost events when the menu is closed for Linux Aura (Closed)

Created:
6 years, 9 months ago by pkotwicz
Modified:
6 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Do not repost events when the menu is closed for Linux Aura. This CL ensures that we do not activate a new window when dismissing the context menu in all cases. Without this CL: - Clicking on a browser window from the wrench menu activates the window - Clicking on non-browser window (e.g. terminal) does not activate the window BUG=349069 TEST=Manual, see comment #20 on the bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258112

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M ui/views/controls/menu/menu_controller.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
pkotwicz
Scott, can you please take a look? I have filed a separate bug (http://crbug.com/345148) to ...
6 years, 9 months ago (2014-03-19 03:38:28 UTC) #1
sky
LGTM https://codereview.chromium.org/204253002/diff/60001/ui/views/controls/menu/menu_controller.cc File ui/views/controls/menu/menu_controller.cc (right): https://codereview.chromium.org/204253002/diff/60001/ui/views/controls/menu/menu_controller.cc#newcode944 ui/views/controls/menu/menu_controller.cc:944: // Do not repost events for Linux Aura. ...
6 years, 9 months ago (2014-03-19 15:36:14 UTC) #2
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 9 months ago (2014-03-19 17:43:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/204253002/100001
6 years, 9 months ago (2014-03-19 17:44:02 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 17:47:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-19 17:47:52 UTC) #6
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 9 months ago (2014-03-19 18:19:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/204253002/100001
6 years, 9 months ago (2014-03-19 18:20:11 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 21:51:04 UTC) #9
Message was sent while issue was closed.
Change committed as 258112

Powered by Google App Engine
This is Rietveld 408576698