Fix use-before-new issue in TestCastSocket.

Fix use-before-new issue in TestCastSocket.

A reference to capturing_net_log_ was passed into the base class constructor
and used before it was fully initialized. For the derived class the initialization
of the members happens stronly after the base constructors completed.

This fixes a bug found by UBSan Vptr.

BUG=617206
Committed: https://crrev.com/ce674bd826bdfc05b1b091ab062c386d56018d76
Cr-Commit-Position: refs/heads/master@{#397846}

[krasin, 2016-06-03 21:42:57]

krasin@google.com changed reviewers:
+ wez@chromium.org

[Wez, 2016-06-03 22:12:17]

wez@chromium.org changed reviewers:
+ kmarshall@chromium.org

[Wez, 2016-06-03 22:12:18]

LGTM as a quick-fix.

Looking at TestCastSocket, it seems that it only overrides two CastSocket
methods, so it would be cleaner to break it into a TestCastSocket that overrides
those, and a helper class to provide the other functions on top.

https://codereview.chromium.org/2042493002/diff/1/extensions/browser/api/cast...
File extensions/browser/api/cast_channel/cast_socket_unittest.cc (right):

https://codereview.chromium.org/2042493002/diff/1/extensions/browser/api/cast...
extensions/browser/api/cast_channel/cast_socket_unittest.cc:188: explicit
TestCastSocket(const net::IPEndPoint& ip_endpoint,
nit: This doesn't need to be explicit, nor does the overload.

[krasin, 2016-06-03 22:20:58]

Thank you, James. I've dropped explicit clauses.

Also, I've taken a quick look at the proposed refactoring, and it seems that
someone with the code knowledge will do a better job, as more than just a
mechanical split could be executed.

https://codereview.chromium.org/2042493002/diff/1/extensions/browser/api/cast...
File extensions/browser/api/cast_channel/cast_socket_unittest.cc (right):

https://codereview.chromium.org/2042493002/diff/1/extensions/browser/api/cast...
extensions/browser/api/cast_channel/cast_socket_unittest.cc:188: explicit
TestCastSocket(const net::IPEndPoint& ip_endpoint,
On 2016/06/03 22:12:18, Wez wrote:
> nit: This doesn't need to be explicit, nor does the overload.

Done.

[krasin, 2016-06-03 22:21:02]

The CQ bit was checked by krasin@google.com

[krasin, 2016-06-03 22:21:02]

The patchset sent to the CQ was uploaded after l-g-t-m from wez@chromium.org
Link to the patchset: https://codereview.chromium.org/2042493002/#ps20001
(title: "drop explicit")

[commit-bot: I haz the power, 2016-06-03 22:21:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2042493002/20001

[Wez, 2016-06-03 22:21:58]

On 2016/06/03 22:20:58, krasin wrote:
> Thank you, James. I've dropped explicit clauses.

Great - thanks for the fix. :)

> Also, I've taken a quick look at the proposed refactoring, and it seems that
> someone with the code knowledge will do a better job, as more than just a
> mechanical split could be executed.

Yes, SGTM!

[commit-bot: I haz the power, 2016-06-03 23:52:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-03 23:55:01]

Description was changed from

==========
Fix use-before-new issue in TestCastSocket.

A reference to capturing_net_log_ was passed into the base class constructor
and used before it was fully initialized. For the derived class the
initialization
of the members happens stronly after the base constructors completed.

This fixes a bug found by UBSan Vptr.

BUG=617206
==========

to

==========
Fix use-before-new issue in TestCastSocket.

A reference to capturing_net_log_ was passed into the base class constructor
and used before it was fully initialized. For the derived class the
initialization
of the members happens stronly after the base constructors completed.

This fixes a bug found by UBSan Vptr.

BUG=617206

Committed: https://crrev.com/ce674bd826bdfc05b1b091ab062c386d56018d76
Cr-Commit-Position: refs/heads/master@{#397846}
==========

[commit-bot: I haz the power, 2016-06-03 23:55:02]

Patchset 2 (id:??) landed as
https://crrev.com/ce674bd826bdfc05b1b091ab062c386d56018d76
Cr-Commit-Position: refs/heads/master@{#397846}