Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: pkg/analyzer/lib/src/dart/element/handle.dart

Issue 2042473002: Remove _DeferredClassElement because ClassElementImpl is now lazy. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/dart/element/element.dart ('k') | pkg/analyzer/lib/src/summary/resynthesize.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/dart/element/handle.dart
diff --git a/pkg/analyzer/lib/src/dart/element/handle.dart b/pkg/analyzer/lib/src/dart/element/handle.dart
index 0e714999944dbdf21edafb64bd87a4b3790633e9..776a26e5eaa78a6f77dd3879056a3cf913c533be 100644
--- a/pkg/analyzer/lib/src/dart/element/handle.dart
+++ b/pkg/analyzer/lib/src/dart/element/handle.dart
@@ -98,67 +98,29 @@ class ClassElementHandle extends ElementHandle implements ClassElement {
List<TypeParameterElement> get typeParameters => actualElement.typeParameters;
@override
- ConstructorElement get unnamedConstructor {
- ensureConstructorsReady();
- return actualElement.unnamedConstructor;
- }
+ ConstructorElement get unnamedConstructor => actualElement.unnamedConstructor;
@override
NamedCompilationUnitMember computeNode() => super.computeNode();
- /**
- * Ensure that [ClassElement.accessors] and [ClassElement.fields] are ready
- * in [actualElement].
- */
- void ensureAccessorsReady() {}
-
- /**
- * The method is called by [ClassElementImpl.getImpl] before returning
- * the [actualElement] as [ClassElementImpl]. At this moment we must ensure
- * that [ClassElementImpl] is fully complete, we cannot continue filling it
- * lazily.
- */
- void ensureActualElementComplete() {}
-
- /**
- * Ensure that [ClassElement.constructors] are ready in [actualElement].
- */
- void ensureConstructorsReady() {}
-
- /**
- * Ensure that [ClassElement.methods] are ready in [actualElement].
- */
- void ensureMethodsReady() {}
-
@override
- FieldElement getField(String fieldName) {
- ensureAccessorsReady();
- return actualElement.getField(fieldName);
- }
+ FieldElement getField(String fieldName) => actualElement.getField(fieldName);
@override
- PropertyAccessorElement getGetter(String getterName) {
- ensureAccessorsReady();
- return actualElement.getGetter(getterName);
- }
+ PropertyAccessorElement getGetter(String getterName) =>
+ actualElement.getGetter(getterName);
@override
- MethodElement getMethod(String methodName) {
- ensureMethodsReady();
- return actualElement.getMethod(methodName);
- }
+ MethodElement getMethod(String methodName) =>
+ actualElement.getMethod(methodName);
@override
- ConstructorElement getNamedConstructor(String name) {
- ensureConstructorsReady();
- return actualElement.getNamedConstructor(name);
- }
+ ConstructorElement getNamedConstructor(String name) =>
+ actualElement.getNamedConstructor(name);
@override
- PropertyAccessorElement getSetter(String setterName) {
- ensureAccessorsReady();
- return actualElement.getSetter(setterName);
- }
+ PropertyAccessorElement getSetter(String setterName) =>
+ actualElement.getSetter(setterName);
@override
bool isSuperConstructorAccessible(ConstructorElement constructor) =>
@@ -166,10 +128,8 @@ class ClassElementHandle extends ElementHandle implements ClassElement {
@override
MethodElement lookUpConcreteMethod(
- String methodName, LibraryElement library) {
- ensureMethodsReady();
- return actualElement.lookUpConcreteMethod(methodName, library);
- }
+ String methodName, LibraryElement library) =>
+ actualElement.lookUpConcreteMethod(methodName, library);
@override
PropertyAccessorElement lookUpGetter(
@@ -178,44 +138,33 @@ class ClassElementHandle extends ElementHandle implements ClassElement {
@override
PropertyAccessorElement lookUpInheritedConcreteGetter(
- String methodName, LibraryElement library) {
- ensureAccessorsReady();
- return actualElement.lookUpInheritedConcreteGetter(methodName, library);
- }
+ String methodName, LibraryElement library) =>
+ actualElement.lookUpInheritedConcreteGetter(methodName, library);
@override
MethodElement lookUpInheritedConcreteMethod(
- String methodName, LibraryElement library) {
- ensureMethodsReady();
- return actualElement.lookUpInheritedConcreteMethod(methodName, library);
- }
+ String methodName, LibraryElement library) =>
+ actualElement.lookUpInheritedConcreteMethod(methodName, library);
@override
PropertyAccessorElement lookUpInheritedConcreteSetter(
- String methodName, LibraryElement library) {
- ensureAccessorsReady();
- return actualElement.lookUpInheritedConcreteSetter(methodName, library);
- }
+ String methodName, LibraryElement library) =>
+ actualElement.lookUpInheritedConcreteSetter(methodName, library);
@override
MethodElement lookUpInheritedMethod(
String methodName, LibraryElement library) {
- ensureMethodsReady();
return actualElement.lookUpInheritedMethod(methodName, library);
}
@override
- MethodElement lookUpMethod(String methodName, LibraryElement library) {
- ensureMethodsReady();
- return actualElement.lookUpMethod(methodName, library);
- }
+ MethodElement lookUpMethod(String methodName, LibraryElement library) =>
+ actualElement.lookUpMethod(methodName, library);
@override
PropertyAccessorElement lookUpSetter(
- String setterName, LibraryElement library) {
- ensureAccessorsReady();
- return actualElement.lookUpSetter(setterName, library);
- }
+ String setterName, LibraryElement library) =>
+ actualElement.lookUpSetter(setterName, library);
}
/**
« no previous file with comments | « pkg/analyzer/lib/src/dart/element/element.dart ('k') | pkg/analyzer/lib/src/summary/resynthesize.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698