Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2042433002: cc: Fix flaky RemoteChannelTest.ReleaseOutputSurfaceDuringCommit. (Closed)

Created:
4 years, 6 months ago by Khushal
Modified:
4 years, 6 months ago
Reviewers:
danakj, vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Fix flaky RemoteChannelTest.ReleaseOutputSurfaceDuringCommit. The test flakes because it expects only 1 BeginMainFrame to be sent from the Scheduler and sets the expectations for commit count and output surface initializations accordingly. Update the test to perform the following: 1) When the first BeginMainFrame request is sent to the server, release the output surface on the client. It would earlier do it for each BeginMainFrame request, do it only for the first one. 2) Make sure that the first commit doesn't go through on the client after the output surface is released till a new output surface is initialized. BUG=612562 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/d2acaecbc0509795e5e2c55dcb39bd22f40da0cc Cr-Commit-Position: refs/heads/master@{#399020}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -19 lines) Patch
M cc/trees/remote_channel_unittest.cc View 1 chunk +31 lines, -19 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Khushal
4 years, 6 months ago (2016-06-03 18:51:29 UTC) #3
Khushal
On 2016/06/03 18:51:29, Khushal wrote: pingy! :)
4 years, 6 months ago (2016-06-08 20:58:36 UTC) #4
danakj
LGTM
4 years, 6 months ago (2016-06-09 20:28:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042433002/1
4 years, 6 months ago (2016-06-09 20:41:15 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 21:30:33 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-09 21:30:46 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 21:33:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2acaecbc0509795e5e2c55dcb39bd22f40da0cc
Cr-Commit-Position: refs/heads/master@{#399020}

Powered by Google App Engine
This is Rietveld 408576698