skia/public/interfaces/image_filter_struct_traits.h - Issue 2042413003: Implement cc::FilterOperation StructTraits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: skia/public/interfaces/image_filter_struct_traits.h

Issue 2042413003: Implement cc::FilterOperation StructTraits (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased + Addressed Enne's comment Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: skia/public/interfaces/image_filter_struct_traits.h

diff --git a/skia/public/interfaces/image_filter_struct_traits.h b/skia/public/interfaces/image_filter_struct_traits.h

index 636dee25660fe055208b04c8bda8dd85dae6cdc3..aa3d003f4591fe3b82b1736d0a3da7b23906a5c6 100644

--- a/skia/public/interfaces/image_filter_struct_traits.h

+++ b/skia/public/interfaces/image_filter_struct_traits.h

@@ -46,8 +46,6 @@ struct StructTraits<skia::mojom::ImageFilter, sk_sp<SkImageFilter>> {

SkFlattenable* flattenable = SkValidatingDeserializeFlattenable(

buffer.data->bytes(), buffer.data->size(),

SkImageFilter::GetFlattenableType());

- if (!flattenable)

- return false;

*out = sk_sp<SkImageFilter>(static_cast<SkImageFilter*>(flattenable));

return true;

}

« no previous file with comments | « cc/output/filter_operation.cc ('k') | skia/public/interfaces/test/struct_traits_unittest.cc » ('j') | no next file with comments »