Notify the HTMLDocumentParser on document element available

third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp

 /*
  * Copyright (C) 2010 Google, Inc. All Rights Reserved.
  * Copyright (C) 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 12 matching lines @@
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "core/html/parser/HTMLConstructionSite.h"
 
 #include "core/HTMLElementFactory.h"
 #include "core/HTMLNames.h"
 #include "core/dom/Comment.h"
 #include "core/dom/DocumentFragment.h"
+#include "core/dom/DocumentParser.h"
 #include "core/dom/DocumentType.h"
 #include "core/dom/Element.h"
 #include "core/dom/ScriptLoader.h"
 #include "core/dom/TemplateContentDocumentFragment.h"
 #include "core/dom/Text.h"
 #include "core/frame/LocalFrame.h"
 #include "core/html/HTMLFormElement.h"
 #include "core/html/HTMLHtmlElement.h"
 #include "core/html/HTMLPlugInElement.h"
 #include "core/html/HTMLScriptElement.h"
@@ skipping 332 matching lines @@
 }
 
 HTMLFormElement* HTMLConstructionSite::takeForm()
 {
     return m_form.release();
 }
 
 void HTMLConstructionSite::dispatchDocumentElementAvailableIfNeeded()
 {
     ASSERT(m_document);
+    m_document->parser()->documentElementAvailable();

[kouhei (in TOK), 2016/06/08 05:09:11]

I'm not a fan of cyclic-dependency introduced here.
HTMLDocumentParser owns HTMLConstructionSite via HTMLTreeBuilder.

Can we remove dispatchDocumentElementAvailableIfNeeded() and move the logic
including this to HTMLHtmlElement::insertedByParser?

[Charlie Harrison, 2016/06/08 22:25:50]

Yeah sure. I agree this is a non ideal architecture. One thing to note is that
|insertedByParser| is called in more places than this method. I've had to make
some changes to get this to work.

     if (m_document->frame() && !m_isParsingFragment) {
         m_document->frame()->loader().dispatchDocumentElementAvailable();
         m_document->frame()->loader().runScriptsAtDocumentElementAvailable();
         // runScriptsAtDocumentElementAvailable might have invalidated m_document.
     }
 }
 
 void HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML(AtomicHTMLToken* token)
 {
     ASSERT(m_document);
@@ skipping 491 matching lines @@
     queueTask(task);
 }
 
 DEFINE_TRACE(HTMLConstructionSite::PendingText)
 {
     visitor->trace(parent);
     visitor->trace(nextChild);
 }
 
 } // namespace blink