third_party/WebKit/LayoutTests/fast/images/width-on-broken-data-src.html - Issue 2042413002: Notify the HTMLDocumentParser on document element available

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/images/width-on-broken-data-src.html

Issue 2042413002: Notify the HTMLDocumentParser on document element available (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix some layout test flakiness Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/passive-mixed-content-iframe.html » ('j') | third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/passive-mixed-content-iframe.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <img src="data:dsa" data-expected-width=20>	2 <img src="data:dsa" data-expected-width=20>

3 <script src="../../resources/check-layout.js"></script>	3 <script src="../../resources/check-layout.js"></script>

4 <p>crbug.com/522673: Return the correct width for images with broken data: uri's .</p>	4 <p>crbug.com/522673: Return the correct width for images with broken data: uri's .</p>

5 <script>	5 <script>

6 checkLayout("img");	6 window.onload = function() {

	7 checkLayout("img");
	kouhei (in TOK) 2016/06/08 05:09:11 Would you explain this change? Would you explain this change? Charlie Harrison 2016/06/08 22:25:50 This is a timing related issue. I think the proble Show quoted text On 2016/06/08 at 05:09:11, kouhei wrote: > Would you explain this change? This is a timing related issue. I think the problem is that we're querying the image state before the image is fully loaded (or processed). Moving the check to onload fixes it. You can also observe the problem if you navigate to: data:text/html;charset=utf-8,<img id='a' src='data:dsa'><script> console.log(document.getElementById('a').width)</script> and data:text/html;charset=utf-8,<img id='a' src='data:dsa'><script>window.onload = function () { console.log(document.getElementById('a').width)}</script> The first one reports 0 width and the second reports 20.
	8 }

7 </script>	9 </script>

8	10

9	11

OLD	NEW