Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2042403002: Revert of [heap] Clear out of live range remembered set slots in large objects. (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Clear out of live range remembered set slots in large objects. (patchset #2 id:20001 of https://codereview.chromium.org/2043713006/ ) Reason for revert: Fails arm sim: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm%20-%20sim/builds/1012 Original issue's description: > [heap] Clear out of live range remembered set slots in large objects. > > BUG=chromium:617882 > LOG=n > > Committed: https://crrev.com/38ad63ff15d7e379423be4c57ae94ae2c9ffb4af > Cr-Commit-Position: refs/heads/master@{#36795} TBR=ulan@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:617882 Committed: https://crrev.com/67af060318aef99e1a8d8c3d9eab771a930e5c3e Cr-Commit-Position: refs/heads/master@{#36799}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -45 lines) Patch
M src/heap/spaces.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/spaces.cc View 2 chunks +0 lines, -14 lines 0 comments Download
D test/mjsunit/regress/regress-617882.js View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [heap] Clear out of live range remembered set slots in large objects.
4 years, 6 months ago (2016-06-07 18:27:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042403002/1
4 years, 6 months ago (2016-06-07 18:27:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 18:28:15 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 18:32:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67af060318aef99e1a8d8c3d9eab771a930e5c3e
Cr-Commit-Position: refs/heads/master@{#36799}

Powered by Google App Engine
This is Rietveld 408576698