pkg/analyzer/lib/src/dart/element/handle.dart - Issue 2042393002: Remove unnecessary overrides of PropertyAccessorElementImpl.operator== and hashCode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/dart/element/handle.dart

Issue 2042393002: Remove unnecessary overrides of PropertyAccessorElementImpl.operator== and hashCode (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analyzer/lib/src/dart/element/element.dart ('k') | pkg/analyzer/test/src/dart/element/element_test.dart » ('j') | pkg/analyzer/test/src/dart/element/element_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analyzer/lib/src/dart/element/handle.dart

diff --git a/pkg/analyzer/lib/src/dart/element/handle.dart b/pkg/analyzer/lib/src/dart/element/handle.dart

index 776a26e5eaa78a6f77dd3879056a3cf913c533be..633fcb0aa6ec9c83c08675560dec0d2760b99e7a 100644

--- a/pkg/analyzer/lib/src/dart/element/handle.dart

+++ b/pkg/analyzer/lib/src/dart/element/handle.dart

@@ -971,10 +971,10 @@ class PropertyAccessorElementHandle extends ExecutableElementHandle

actualElement.correspondingSetter;

@override

- bool get isGetter => actualElement.isGetter;

+ bool get isGetter => !isSetter;

@override

- bool get isSetter => actualElement.isSetter;

+ bool get isSetter => location.components.last.endsWith('=');

@override

ElementKind get kind {