Remove unnecessary overrides of PropertyAccessorElementImpl.operator== and hashCode

Remove unnecessary overrides of PropertyAccessorElementImpl.operator== and hashCode

It turns out that these overrides aren't necessary, since the
element's location contains enough information to distinguish between
getters and setters.  Removing the overrides makes
PropertyAccessorElementImpl's behavior match that of
PropertyAccessorElementHandle, which is important when summaries are
in use.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/f5ef3232ea367ec890de27095f2ef749b0859c7c

[Paul Berry, 2016-06-07 18:04:40]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-06-07 18:09:05]

lgtm

https://codereview.chromium.org/2042393002/diff/1/pkg/analyzer/test/src/dart/...
File pkg/analyzer/test/src/dart/element/element_test.dart (right):

https://codereview.chromium.org/2042393002/diff/1/pkg/analyzer/test/src/dart/...
pkg/analyzer/test/src/dart/element/element_test.dart:4189: class
PropertyAccessorElementImplTest extends EngineTestCase {
"PropertyAccessorElementImplTest" --> "PropertyAccessorElementHandleTest"?

[Paul Berry, 2016-06-07 18:26:46]

https://codereview.chromium.org/2042393002/diff/1/pkg/analyzer/test/src/dart/...
File pkg/analyzer/test/src/dart/element/element_test.dart (right):

https://codereview.chromium.org/2042393002/diff/1/pkg/analyzer/test/src/dart/...
pkg/analyzer/test/src/dart/element/element_test.dart:4189: class
PropertyAccessorElementImplTest extends EngineTestCase {
On 2016/06/07 18:09:05, Brian Wilkerson wrote:
> "PropertyAccessorElementImplTest" --> "PropertyAccessorElementHandleTest"?

Based purely on functionality, I don't have a preference; since these tests
compare the behavior of PropertyAccessorElementImpl to
PropertyAccessorElementHandle, both names seem equally good.

However, based on the fact that (a) the code that was in error was in
PropertyAccessorElementImpl, (b) the other tests in this file are for testing
the "Impl" classes, and (c) the test methods are called "matchesHandle", I
prefer to leave the name as is.

If you have a strong argument that the test should be renamed I'd be glad to do
it as a follow-up CL.

[Paul Berry, 2016-06-07 18:26:55]

Description was changed from

==========
Remove unnecessary overrides of PropertyAccessorElementImpl.operator== and
hashCode

It turns out that these overrides aren't necessary, since the
element's location contains enough information to distinguish between
getters and setters.  Removing the overrides makes
PropertyAccessorElementImpl's behavior match that of
PropertyAccessorElementHandle, which is important when summaries are
in use.
==========

to

==========
Remove unnecessary overrides of PropertyAccessorElementImpl.operator== and
hashCode

It turns out that these overrides aren't necessary, since the
element's location contains enough information to distinguish between
getters and setters.  Removing the overrides makes
PropertyAccessorElementImpl's behavior match that of
PropertyAccessorElementHandle, which is important when summaries are
in use.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f5ef3232ea367ec890de27095f2ef749b0859c7c
==========

[Paul Berry, 2016-06-07 18:26:57]

Committed patchset #1 (id:1) manually as
f5ef3232ea367ec890de27095f2ef749b0859c7c (presubmit successful).