Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: third_party/WebKit/Source/core/input/EventHandler.h

Issue 2042333006: Reset drag state variables on mouse up (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Applying the comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 275 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 // Same applied to dispatchMouseEvent() above. 286 // Same applied to dispatchMouseEvent() above.
287 WebInputEventResult updatePointerTargetAndDispatchEvents(const AtomicString& mouseEventType, Node* target, 287 WebInputEventResult updatePointerTargetAndDispatchEvents(const AtomicString& mouseEventType, Node* target,
288 int clickCount, const PlatformMouseEvent&); 288 int clickCount, const PlatformMouseEvent&);
289 289
290 WebInputEventResult dispatchDragEvent(const AtomicString& eventType, Node* t arget, const PlatformMouseEvent&, DataTransfer*); 290 WebInputEventResult dispatchDragEvent(const AtomicString& eventType, Node* t arget, const PlatformMouseEvent&, DataTransfer*);
291 291
292 void clearDragDataTransfer(); 292 void clearDragDataTransfer();
293 293
294 bool handleDrag(const MouseEventWithHitTestResults&, DragInitiator); 294 bool handleDrag(const MouseEventWithHitTestResults&, DragInitiator);
295 bool tryStartDrag(const MouseEventWithHitTestResults&); 295 bool tryStartDrag(const MouseEventWithHitTestResults&);
296
297 // Clears drag target and related states. It is called when drag is done or canceled.
296 void clearDragState(); 298 void clearDragState();
297 299
300 // Resets the state that indicates the next events could cause a drag. It is called when
301 // we realize the next events should not cause drag based on the drag heuris tics.
302 void clearDragHeuristicState();
303
298 WebInputEventResult dispatchDragSrcEvent(const AtomicString& eventType, cons t PlatformMouseEvent&); 304 WebInputEventResult dispatchDragSrcEvent(const AtomicString& eventType, cons t PlatformMouseEvent&);
299 305
300 bool dragHysteresisExceeded(const IntPoint&) const; 306 bool dragHysteresisExceeded(const IntPoint&) const;
301 307
302 WebInputEventResult passMousePressEventToSubframe(MouseEventWithHitTestResul ts&, LocalFrame* subframe); 308 WebInputEventResult passMousePressEventToSubframe(MouseEventWithHitTestResul ts&, LocalFrame* subframe);
303 WebInputEventResult passMouseMoveEventToSubframe(MouseEventWithHitTestResult s&, LocalFrame* subframe, HitTestResult* hoveredNode = nullptr); 309 WebInputEventResult passMouseMoveEventToSubframe(MouseEventWithHitTestResult s&, LocalFrame* subframe, HitTestResult* hoveredNode = nullptr);
304 WebInputEventResult passMouseReleaseEventToSubframe(MouseEventWithHitTestRes ults&, LocalFrame* subframe); 310 WebInputEventResult passMouseReleaseEventToSubframe(MouseEventWithHitTestRes ults&, LocalFrame* subframe);
305 311
306 bool passMousePressEventToScrollbar(MouseEventWithHitTestResults&); 312 bool passMousePressEventToScrollbar(MouseEventWithHitTestResults&);
307 313
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
397 403
398 // Set on GestureTapDown if the |pointerdown| event corresponding to the 404 // Set on GestureTapDown if the |pointerdown| event corresponding to the
399 // triggering |touchstart| event was canceled. This suppresses mouse event 405 // triggering |touchstart| event was canceled. This suppresses mouse event
400 // firing for the current gesture sequence (i.e. until next GestureTapDown). 406 // firing for the current gesture sequence (i.e. until next GestureTapDown).
401 bool m_suppressMouseEventsFromGestures; 407 bool m_suppressMouseEventsFromGestures;
402 }; 408 };
403 409
404 } // namespace blink 410 } // namespace blink
405 411
406 #endif // EventHandler_h 412 #endif // EventHandler_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698