Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 2042313002: Switch to a whitelist for manual mip-map generation (Closed)

Created:
4 years, 6 months ago by Brian Osman
Modified:
4 years, 6 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Switch to a whitelist for manual mip-map generation Due to performance regression on various GPUs, we're only going to use the new draw-call based mip-mapper when necessary. Of the bots where we have test coverage, that means Intel and Mac-NVIDIA. We also had failures on our AMD 7770 bots - I'm upgrading the drivers on those two machines, and I'm leaving them out of the whitelist for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2042313002 Committed: https://skia.googlesource.com/skia/+/131ff13f66582204a965c7f56557dc4d0d1a3d33

Patch Set 1 #

Patch Set 2 : Add ATI to whitelist #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M src/gpu/gl/GrGLCaps.cpp View 1 1 chunk +7 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLUtil.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLUtil.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042313002/1
4 years, 6 months ago (2016-06-07 16:06:15 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042313002/20001
4 years, 6 months ago (2016-06-07 17:43:55 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-07 17:57:10 UTC) #8
Brian Osman
4 years, 6 months ago (2016-06-07 19:10:05 UTC) #10
bsalomon
lgtm
4 years, 6 months ago (2016-06-07 20:05:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042313002/20001
4 years, 6 months ago (2016-06-07 20:31:49 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 21:22:49 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/131ff13f66582204a965c7f56557dc4d0d1a3d33

Powered by Google App Engine
This is Rietveld 408576698