Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 20423: Preliminary fullscreen mode support.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 3 months ago by Peter Kasting
Modified:
6 years ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Preliminary fullscreen mode support. There is no UI for this (yet), just F11 to toggle in and out. BUG=534 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9950

Patch Set 1 #

Total comments: 10

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -39 lines) Patch
M chrome/app/chrome_dll.rc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/chrome_dll_resource.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/browser.h View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/browser.cc View 6 chunks +45 lines, -28 lines 0 comments Download
M chrome/browser/browser_window.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/views/bookmark_bar_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/views/bookmark_bar_view.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/views/frame/browser_view.h View 1 3 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/views/frame/browser_view.cc View 1 5 chunks +76 lines, -6 lines 0 comments Download
M chrome/browser/views/frame/opaque_non_client_view.cc View 5 chunks +12 lines, -2 lines 0 comments Download
M chrome/test/test_browser_window.h View 1 chunk +2 lines, -0 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 4 (0 generated)
Peter Kasting
8 years, 3 months ago (2009-02-17 17:43:34 UTC) #1
sky
http://codereview.chromium.org/20423/diff/1/4 File chrome/app/chrome_dll.rc (right): http://codereview.chromium.org/20423/diff/1/4#newcode54 Line 54: VK_F11, IDC_FULLSCREEN, VIRTKEY Shouldn't that be FULL_SCREEN? I ...
8 years, 3 months ago (2009-02-17 18:28:51 UTC) #2
Peter Kasting
http://codereview.chromium.org/20423/diff/1/4 File chrome/app/chrome_dll.rc (right): http://codereview.chromium.org/20423/diff/1/4#newcode54 Line 54: VK_F11, IDC_FULLSCREEN, VIRTKEY On 2009/02/17 18:28:51, sky wrote: ...
8 years, 3 months ago (2009-02-18 17:17:44 UTC) #3
sky
8 years, 3 months ago (2009-02-18 17:47:56 UTC) #4
> No, because this is "Fullscreen Mode", not "Full Screen Mode".

Oh, that makes it so much clearer:)

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06