Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2042293002: Adds status entries for initializing_formal tests. (Closed)

Created:
4 years, 6 months ago by eernst
Modified:
4 years, 6 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, floitsch
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adds status entries for initializing_formal tests. This CL should fix the problem that arose with commit 543a51ff3eb1488e2c1938bfcd8779f0d634900c. Here's the description from that CL: This CL adds tests for previously uncovered elements of the semantics and includes fixes such that the desired behavior is obtained. In particular, an `isInitializingFormal` element may now occur in contexts where it wasn't expected until now, and changes were made to handle it. It is also checked that a capture of an initializing formal (in a function literal) captures the parameter, not the field. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/c3dfe51295378d1ac919dea6374b75eca7b0de4f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -53 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 4 chunks +17 lines, -4 lines 0 comments Download
M pkg/dart_messages/lib/shared_messages.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A + tests/language/initializing_formal_capture_test.dart View 1 chunk +9 lines, -8 lines 0 comments Download
A + tests/language/initializing_formal_final_test.dart View 1 chunk +8 lines, -16 lines 0 comments Download
A + tests/language/initializing_formal_promotion_test.dart View 1 chunk +16 lines, -14 lines 0 comments Download
A + tests/language/initializing_formal_type_test.dart View 1 chunk +9 lines, -9 lines 0 comments Download
M tests/language/language.status View 2 chunks +6 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
eernst
https://codereview.chromium.org/2039833002/, with the status problems fixed.
4 years, 6 months ago (2016-06-07 15:57:08 UTC) #2
Johnni Winther
lgtm
4 years, 6 months ago (2016-06-08 07:25:27 UTC) #3
eernst
4 years, 6 months ago (2016-06-08 08:50:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c3dfe51295378d1ac919dea6374b75eca7b0de4f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698