Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Unified Diff: masters/master.chromium.lkgr/master_lkgr_cfg.py

Issue 2042283005: lkgr: Convert some linux asan bots to recipes/ (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master
Patch Set: merge https://codereview.chromium.org/2047323003/ Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium/config.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: masters/master.chromium.lkgr/master_lkgr_cfg.py
diff --git a/masters/master.chromium.lkgr/master_lkgr_cfg.py b/masters/master.chromium.lkgr/master_lkgr_cfg.py
index ffa1a9848ccce141b7d8d21036afd57e47f0f215..212ca67403297b1d2734690d0b1cc5e5870f4dd8 100644
--- a/masters/master.chromium.lkgr/master_lkgr_cfg.py
+++ b/masters/master.chromium.lkgr/master_lkgr_cfg.py
@@ -18,9 +18,7 @@ B = helper.Builder
F = helper.Factory
S = helper.Scheduler
-def win_out(): return chromium_factory.ChromiumFactory('src/out', 'win32')
def linux(): return chromium_factory.ChromiumFactory('src/build', 'linux2')
-def mac(): return chromium_factory.ChromiumFactory('src/build', 'darwin')
m_annotator = annotator_factory.AnnotatorFactory()
@@ -74,57 +72,23 @@ F('mac_asan_dbg', m_annotator.BaseFactory(recipe='chromium'))
## Linux
################################################################################
-asan_rel_gyp = ('asan=1 lsan=1 sanitizer_coverage=edge '
- 'v8_enable_verify_heap=1 enable_ipc_fuzzer=1 ')
B('ASAN Release', 'linux_asan_rel', 'compile', 'chromium_lkgr')
-F('linux_asan_rel', linux().ChromiumASANFactory(
- compile_timeout=2400, # We started seeing 29 minute links, bug 360158
- clobber=True,
- options=['--compiler=goma-clang', 'chromium_builder_asan'],
- factory_properties={
- 'cf_archive_build': ActiveMaster.is_production_host,
- 'cf_archive_name': 'asan',
- 'gs_bucket': 'gs://chromium-browser-asan',
- 'gs_acl': 'public-read',
- 'gclient_env': {'GYP_DEFINES': asan_rel_gyp},
- 'use_mb': True,
- }))
+F('linux_asan_rel', m_annotator.BaseFactory(recipe='chromium',
+ # We started seeing 29 minute links, bug 360158
+ timeout=2400))
-linux_media_gyp = (' proprietary_codecs=1 ffmpeg_branding=ChromeOS')
B('ASAN Release Media', 'linux_asan_rel_media',
'compile', 'chromium_lkgr')
-F('linux_asan_rel_media', linux().ChromiumASANFactory(
- compile_timeout=2400, # We started seeing 29 minute links, bug 360158
- clobber=True,
- options=['--compiler=goma-clang', 'chromium_builder_asan'],
- factory_properties={
- 'cf_archive_build': ActiveMaster.is_production_host,
- 'cf_archive_name': 'asan',
- 'gs_bucket': 'gs://chrome-test-builds/media',
- 'gclient_env': {'GYP_DEFINES': asan_rel_gyp +
- linux_media_gyp},
- 'use_mb': True,
- }))
-
-asan_debug_gyp = ('asan=1 lsan=1 sanitizer_coverage=edge enable_ipc_fuzzer=1 ')
+F('linux_asan_rel_media', m_annotator.BaseFactory(recipe='chromium',
+ # We started seeing 29 minute links, bug 360158
+ timeout=2400))
B('ASAN Debug', 'linux_asan_dbg', 'compile', 'chromium_lkgr')
-F('linux_asan_dbg', linux().ChromiumASANFactory(
- clobber=True,
- target='Debug',
- options=['--compiler=goma-clang', 'chromium_builder_asan'],
- factory_properties={
- 'cf_archive_build': ActiveMaster.is_production_host,
- 'cf_archive_name': 'asan',
- 'gs_bucket': 'gs://chromium-browser-asan',
- 'gs_acl': 'public-read',
- 'gclient_env': {'GYP_DEFINES': asan_debug_gyp},
- 'use_mb': True,
- }))
-
-asan_chromiumos_rel_gyp = ('%s chromeos=1' % asan_rel_gyp)
+F('linux_asan_dbg', m_annotator.BaseFactory(recipe='chromium'))
+asan_chromiumos_rel_gyp = ('asan=1 lsan=1 sanitizer_coverage=edge '
+ 'v8_enable_verify_heap=1 enable_ipc_fuzzer=1 chromeos=1')
B('ChromiumOS ASAN Release', 'linux_chromiumos_asan_rel', 'compile',
'chromium_lkgr')
F('linux_chromiumos_asan_rel', linux().ChromiumASANFactory(
@@ -143,9 +107,9 @@ F('linux_chromiumos_asan_rel', linux().ChromiumASANFactory(
asan_ia32_v8_arm = ('asan=1 sanitizer_coverage=edge disable_nacl=1 '
'v8_target_arch=arm host_arch=x86_64 target_arch=ia32 '
- 'v8_enable_verify_heap=1 enable_ipc_fuzzer=1 ')
+ 'v8_enable_verify_heap=1 ')
-asan_ia32_v8_arm_rel = asan_ia32_v8_arm
+asan_ia32_v8_arm_rel = asan_ia32_v8_arm + 'enable_ipc_fuzzer=1 '
# The build process is described at
# https://sites.google.com/a/chromium.org/dev/developers/testing/addresssanitizer#TOC-Building-with-v8_target_arch-arm
@@ -182,6 +146,7 @@ F('linux_asan_rel_ia32_v8_arm', linux().ChromiumASANFactory(
'use_mb': True,
}))
+linux_media_gyp = (' proprietary_codecs=1 ffmpeg_branding=ChromeOS')
B('ASan Release Media (32-bit x86 with V8-ARM)',
'linux_asan_rel_media_ia32_v8_arm',
'compile', 'chromium_lkgr')
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium/config.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698