src/snapshot/mksnapshot.cc - Issue 2042253002: [icu] Support loading data file from default location

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/snapshot/mksnapshot.cc

Issue 2042253002: [icu] Support loading data file from default location (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/snapshot/mksnapshot.cc

diff --git a/src/snapshot/mksnapshot.cc b/src/snapshot/mksnapshot.cc

index c38f92f5b17795ab9a5a25c9a399b4d1bb6caeb4..f4362e5077e1231e2e57ccaf06ccc9769ebaae61 100644

--- a/src/snapshot/mksnapshot.cc

+++ b/src/snapshot/mksnapshot.cc

@@ -150,7 +150,7 @@ int main(int argc, char** argv) {

}

i::CpuFeatures::Probe(true);

- V8::InitializeICU();

+ V8::InitializeICUDefaultLocation(argv[0]);

v8::Platform* platform = v8::platform::CreateDefaultPlatform();

v8::V8::InitializePlatform(platform);

v8::V8::Initialize();