samples/shell.cc - Issue 2042253002: [icu] Support loading data file from default location

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samples/shell.cc

Issue 2042253002: [icu] Support loading data file from default location (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: samples/shell.cc

diff --git a/samples/shell.cc b/samples/shell.cc

index b89ffdd180e9b2d49fa30e5d29f4d50334a795f8..ad9b1aba8bfd8b30be150bccb489f2ee31c4240f 100644

--- a/samples/shell.cc

+++ b/samples/shell.cc

@@ -75,7 +75,7 @@ class ShellArrayBufferAllocator : public v8::ArrayBuffer::Allocator {

int main(int argc, char* argv[]) {

- v8::V8::InitializeICU();

+ v8::V8::InitializeICUDefaultLocation(argv[0]);

v8::V8::InitializeExternalStartupData(argv[0]);

v8::Platform* platform = v8::platform::CreateDefaultPlatform();

v8::V8::InitializePlatform(platform);