src/d8.cc - Issue 2042253002: [icu] Support loading data file from default location

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/d8.cc

Issue 2042253002: [icu] Support loading data file from default location (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Format Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/d8.cc

diff --git a/src/d8.cc b/src/d8.cc

index 7c955dacb929e682c21797f06c45cabc78e9bc96..8c0f82a3117245f0e6e6a1202db20553d3de111b 100644

--- a/src/d8.cc

+++ b/src/d8.cc

@@ -2422,7 +2422,7 @@ int Shell::Main(int argc, char* argv[]) {

#endif // defined(_MSC_VER)

#endif // defined(_WIN32) || defined(_WIN64)

if (!SetOptions(argc, argv)) return 1;

- v8::V8::InitializeICU(options.icu_data_file);

+ v8::V8::InitializeICUDefaultLocation(argv[0], options.icu_data_file);

#ifndef V8_SHARED

g_platform = i::FLAG_verify_predictable

? new PredictablePlatform()

« no previous file with comments | « src/base/file-utils.cc ('k') | src/icu_util.h » ('j') | no next file with comments »