chrome/browser/ui/tab_helpers.cc - Issue 2042243004: Construct the site engagement helper with a site engagement service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tab_helpers.cc

Issue 2042243004: Construct the site engagement helper with a site engagement service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use committed not visible URL Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/tab_helpers.cc

diff --git a/chrome/browser/ui/tab_helpers.cc b/chrome/browser/ui/tab_helpers.cc

index 1790123cf3de81cc92a57ebc0d79d43df7a640be..160249931dacc396340943dad7ba5498d8ee1668 100644

--- a/chrome/browser/ui/tab_helpers.cc

+++ b/chrome/browser/ui/tab_helpers.cc

@@ -172,8 +172,11 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {

prerender::PrerenderTabHelper::CreateForWebContents(web_contents);

SearchTabHelper::CreateForWebContents(web_contents);

ChromeSecurityStateModelClient::CreateForWebContents(web_contents);

- if (SiteEngagementService::IsEnabled())

- SiteEngagementService::Helper::CreateForWebContents(web_contents);

+ if (SiteEngagementService::IsEnabled()) {

+ SiteEngagementService::Helper::CreateForWebContents(

+ web_contents, SiteEngagementService::Get(Profile::FromBrowserContext(

+ web_contents->GetBrowserContext())));

+ }

subresource_filter::ContentSubresourceFilterDriverFactory::

CreateForWebContents(web_contents);

// TODO(vabr): Remove TabSpecificContentSettings from here once their function

« chrome/browser/engagement/site_engagement_helper.cc ('K') | « chrome/browser/engagement/site_engagement_service_unittest.cc ('k') | no next file » | no next file with comments »