chrome/browser/engagement/site_engagement_helper_unittest.cc - Issue 2042243004: Construct the site engagement helper with a site engagement service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_helper_unittest.cc

Issue 2042243004: Construct the site engagement helper with a site engagement service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use committed not visible URL Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/engagement/site_engagement_helper.cc ('K') | « chrome/browser/engagement/site_engagement_helper.cc ('k') | chrome/browser/engagement/site_engagement_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/engagement/site_engagement_helper_unittest.cc

diff --git a/chrome/browser/engagement/site_engagement_helper_unittest.cc b/chrome/browser/engagement/site_engagement_helper_unittest.cc

index 6f92ab3242495984740e457b6f1021833eafe3e8..18859565be51a5e2bd414f7ed29c857f21d48e3c 100644

--- a/chrome/browser/engagement/site_engagement_helper_unittest.cc

+++ b/chrome/browser/engagement/site_engagement_helper_unittest.cc

@@ -27,7 +27,8 @@ class SiteEngagementHelperTest : public ChromeRenderViewHostTestHarness {

}

SiteEngagementService::Helper* GetHelper(content::WebContents* web_contents) {

- SiteEngagementService::Helper::CreateForWebContents(web_contents);

+ SiteEngagementService* service = SiteEngagementService::Get(profile());

+ SiteEngagementService::Helper::CreateForWebContents(web_contents, service);

SiteEngagementService::Helper* helper =

SiteEngagementService::Helper::FromWebContents(web_contents);