Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Issue 2042153002: Check node->layoutObject in CaretBase::caretLayoutObject (Closed)

Created:
4 years, 6 months ago by yoichio
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Check node->layoutObject in CaretBase::caretLayoutObject In CaretBase::caretLayoutObject(Node* node), if caretRendersInsideNode(node) calls HTMLMeterElement::canContainRangeEndPoint, it updates the layout tree. It means LayoutObject for the METER can be deleted. This is bad design. We should make caret painting algorithm clean. BUG=608817 Review-Url: https://codereview.chromium.org/1972523002 Cr-Commit-Position: refs/heads/master@{#395822} (cherry picked from commit e4edfb63d1b068c5ab5dc6b91edf75c108ebc433) Committed: https://chromium.googlesource.com/chromium/src/+/59c23e7f2a1eeeafa8040eb50a193f2e3a29a02f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M third_party/WebKit/Source/core/editing/CaretBase.cpp View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
yoichio
4 years, 6 months ago (2016-06-07 02:23:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
59c23e7f2a1eeeafa8040eb50a193f2e3a29a02f.

Powered by Google App Engine
This is Rietveld 408576698