Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2042143002: Strengthen GpuRasterizationConcavePathsPagetest test. (Closed)

Created:
4 years, 6 months ago by vmiura
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, Stephen White
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Strengthen GpuRasterizationConcavePathsPagetest test. This test was passing when the entire 'pacman' image area was filled with the 'interior' color. This change ensures that we test pixels on the exterior and interior of the paths, within the pacman's bounds. R=kbr@chromium.org BUG=617805 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/3b4f64f3c1564a04a688ea3fcefe3f5c4fe339fa Cr-Commit-Position: refs/heads/master@{#398234}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M content/test/gpu/page_sets/gpu_rasterization_tests.py View 1 chunk +12 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
vmiura
PTAL
4 years, 6 months ago (2016-06-07 01:54:10 UTC) #2
Ken Russell (switch to Gerrit)
LGTM. Let's send this through the CQ and see if any of the existing bots ...
4 years, 6 months ago (2016-06-07 01:56:29 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042143002/1
4 years, 6 months ago (2016-06-07 01:56:38 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-07 04:35:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042143002/1
4 years, 6 months ago (2016-06-07 05:22:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 05:29:04 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3b4f64f3c1564a04a688ea3fcefe3f5c4fe339fa Cr-Commit-Position: refs/heads/master@{#398234}
4 years, 6 months ago (2016-06-07 05:31:58 UTC) #12
Geoff Lang
On 2016/06/07 05:31:58, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 6 months ago (2016-06-07 17:08:52 UTC) #13
Geoff Lang
4 years, 6 months ago (2016-06-07 17:09:44 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2040143003/ by geofflang@chromium.org.

The reason for reverting is: Broke the GpuRasterization.ConcavePaths test on
Nexus 9.
https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Debug%20%28N....

Powered by Google App Engine
This is Rietveld 408576698