Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2042123003: [heap] Fix chunk map removal for large objects. (Closed)

Created:
4 years, 6 months ago by Hannes Payer (out of office)
Modified:
4 years, 6 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Fix chunk map removal for large objects. BUG= Committed: https://crrev.com/65dac7f8ead2eb09d417ecaaae0164699edfd510 Cr-Commit-Position: refs/heads/master@{#36802}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/heap/spaces.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Lippautz
lgtm
4 years, 6 months ago (2016-06-07 21:15:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042123003/1
4 years, 6 months ago (2016-06-07 21:22:21 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 21:46:47 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/65dac7f8ead2eb09d417ecaaae0164699edfd510 Cr-Commit-Position: refs/heads/master@{#36802}
4 years, 6 months ago (2016-06-07 21:50:52 UTC) #7
Benedikt Meurer
4 years, 6 months ago (2016-06-08 03:48:01 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2046283002/ by bmeurer@chromium.org.

The reason for reverting is: Fails on noi18n debug build
(https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%2...),
please take a look..

Powered by Google App Engine
This is Rietveld 408576698