Revert of Make CSSComputedStyledeclaration::getPropertyCSSValue return const

Revert of Make CSSComputedStyledeclaration::getPropertyCSSValue return const (patchset #3 id:40001 of https://codereview.chromium.org/2034013002/ )

Reason for revert:
"""
../../third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:14:15: error: cannot initialize a variable of type 'blink::CSSValue *' with an rvalue of type 'const blink::CSSValue *'
    CSSValue* cssValue = m_computedStyleDeclaration->getPropertyCSSValueInternal(propertyID);
"""

https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20TSan%20Builder/builds/23734/steps/compile/logs/stdio

Original issue's description:
> Make CSSComputedStyledeclaration::getPropertyCSSValue return const
>
> Make CSSComputedStyledeclaration::getPropertyCSSValue() return a const
> CSSValue* instead of a regular CSSValue*. This required changing
> CSSStyleDeclaration::getPropertyCSSValueInternal() return a const
> CSSValue* as well, and marking CSSValueList::copy() as a const method
> (which it already was, it was just missing the const modifier). This is
> pre-work for making CSSValueList store const CSSValues.
>
> This patch is mostly mechanical changes, but does contain one logic
> change: the static method mergeTextDecorationValues in EditingStyle
> needs to be changed since it modifies a CSSValueList that points inside
> the mutable style. Instead, the function is changed to take two
> CSSValueLists and return a new one, and the callsite is changed to
> replace the old CSSValueList with the new one in the style rather than
> modifying the old CSSValueList in-place.
>
> BUG=526586
>
> Committed: https://crrev.com/5896ec297d9240b691e7f70a239498b795531dc1
> Cr-Commit-Position: refs/heads/master@{#398151}

TBR=haraken@chromium.org,timloh@chromium.org,yukishiino@chromium.org,sashab@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=526586
Committed: https://crrev.com/41b2e7dad0fb637ebcf9dbd6c0e60d4bfbde48ee
Cr-Commit-Position: refs/heads/master@{#398156}

[erikchen, 2016-06-06 23:11:15]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-06-06 23:11:16]

Created Revert of Make CSSComputedStyledeclaration::getPropertyCSSValue return
const

[commit-bot: I haz the power, 2016-06-06 23:12:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2042113002/1

[commit-bot: I haz the power, 2016-06-06 23:12:51]

Description was changed from

==========
Revert of Make CSSComputedStyledeclaration::getPropertyCSSValue return const
(patchset #3 id:40001 of https://codereview.chromium.org/2034013002/ )

Reason for revert:
"""
../../third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:14:15:
error: cannot initialize a variable of type 'blink::CSSValue *' with an rvalue
of type 'const blink::CSSValue *'
    CSSValue* cssValue =
m_computedStyleDeclaration->getPropertyCSSValueInternal(propertyID);
"""

https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20...

Original issue's description:
> Make CSSComputedStyledeclaration::getPropertyCSSValue return const
> 
> Make CSSComputedStyledeclaration::getPropertyCSSValue() return a const
> CSSValue* instead of a regular CSSValue*. This required changing
> CSSStyleDeclaration::getPropertyCSSValueInternal() return a const
> CSSValue* as well, and marking CSSValueList::copy() as a const method
> (which it already was, it was just missing the const modifier). This is
> pre-work for making CSSValueList store const CSSValues.
> 
> This patch is mostly mechanical changes, but does contain one logic
> change: the static method mergeTextDecorationValues in EditingStyle
> needs to be changed since it modifies a CSSValueList that points inside
> the mutable style. Instead, the function is changed to take two
> CSSValueLists and return a new one, and the callsite is changed to
> replace the old CSSValueList with the new one in the style rather than
> modifying the old CSSValueList in-place.
> 
> BUG=526586
> 
> Committed: https://crrev.com/5896ec297d9240b691e7f70a239498b795531dc1
> Cr-Commit-Position: refs/heads/master@{#398151}

TBR=haraken@chromium.org,timloh@chromium.org,yukishiino@chromium.org,sashab@c...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=526586
==========

to

==========
Revert of Make CSSComputedStyledeclaration::getPropertyCSSValue return const
(patchset #3 id:40001 of https://codereview.chromium.org/2034013002/ )

Reason for revert:
"""
../../third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:14:15:
error: cannot initialize a variable of type 'blink::CSSValue *' with an rvalue
of type 'const blink::CSSValue *'
    CSSValue* cssValue =
m_computedStyleDeclaration->getPropertyCSSValueInternal(propertyID);
"""

https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20...

Original issue's description:
> Make CSSComputedStyledeclaration::getPropertyCSSValue return const
> 
> Make CSSComputedStyledeclaration::getPropertyCSSValue() return a const
> CSSValue* instead of a regular CSSValue*. This required changing
> CSSStyleDeclaration::getPropertyCSSValueInternal() return a const
> CSSValue* as well, and marking CSSValueList::copy() as a const method
> (which it already was, it was just missing the const modifier). This is
> pre-work for making CSSValueList store const CSSValues.
> 
> This patch is mostly mechanical changes, but does contain one logic
> change: the static method mergeTextDecorationValues in EditingStyle
> needs to be changed since it modifies a CSSValueList that points inside
> the mutable style. Instead, the function is changed to take two
> CSSValueLists and return a new one, and the callsite is changed to
> replace the old CSSValueList with the new one in the style rather than
> modifying the old CSSValueList in-place.
> 
> BUG=526586
> 
> Committed: https://crrev.com/5896ec297d9240b691e7f70a239498b795531dc1
> Cr-Commit-Position: refs/heads/master@{#398151}

TBR=haraken@chromium.org,timloh@chromium.org,yukishiino@chromium.org,sashab@c...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=526586
==========

[commit-bot: I haz the power, 2016-06-06 23:12:52]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-06 23:14:06]

Description was changed from

==========
Revert of Make CSSComputedStyledeclaration::getPropertyCSSValue return const
(patchset #3 id:40001 of https://codereview.chromium.org/2034013002/ )

Reason for revert:
"""
../../third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:14:15:
error: cannot initialize a variable of type 'blink::CSSValue *' with an rvalue
of type 'const blink::CSSValue *'
    CSSValue* cssValue =
m_computedStyleDeclaration->getPropertyCSSValueInternal(propertyID);
"""

https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20...

Original issue's description:
> Make CSSComputedStyledeclaration::getPropertyCSSValue return const
> 
> Make CSSComputedStyledeclaration::getPropertyCSSValue() return a const
> CSSValue* instead of a regular CSSValue*. This required changing
> CSSStyleDeclaration::getPropertyCSSValueInternal() return a const
> CSSValue* as well, and marking CSSValueList::copy() as a const method
> (which it already was, it was just missing the const modifier). This is
> pre-work for making CSSValueList store const CSSValues.
> 
> This patch is mostly mechanical changes, but does contain one logic
> change: the static method mergeTextDecorationValues in EditingStyle
> needs to be changed since it modifies a CSSValueList that points inside
> the mutable style. Instead, the function is changed to take two
> CSSValueLists and return a new one, and the callsite is changed to
> replace the old CSSValueList with the new one in the style rather than
> modifying the old CSSValueList in-place.
> 
> BUG=526586
> 
> Committed: https://crrev.com/5896ec297d9240b691e7f70a239498b795531dc1
> Cr-Commit-Position: refs/heads/master@{#398151}

TBR=haraken@chromium.org,timloh@chromium.org,yukishiino@chromium.org,sashab@c...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=526586
==========

to

==========
Revert of Make CSSComputedStyledeclaration::getPropertyCSSValue return const
(patchset #3 id:40001 of https://codereview.chromium.org/2034013002/ )

Reason for revert:
"""
../../third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:14:15:
error: cannot initialize a variable of type 'blink::CSSValue *' with an rvalue
of type 'const blink::CSSValue *'
    CSSValue* cssValue =
m_computedStyleDeclaration->getPropertyCSSValueInternal(propertyID);
"""

https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20...

Original issue's description:
> Make CSSComputedStyledeclaration::getPropertyCSSValue return const
>
> Make CSSComputedStyledeclaration::getPropertyCSSValue() return a const
> CSSValue* instead of a regular CSSValue*. This required changing
> CSSStyleDeclaration::getPropertyCSSValueInternal() return a const
> CSSValue* as well, and marking CSSValueList::copy() as a const method
> (which it already was, it was just missing the const modifier). This is
> pre-work for making CSSValueList store const CSSValues.
>
> This patch is mostly mechanical changes, but does contain one logic
> change: the static method mergeTextDecorationValues in EditingStyle
> needs to be changed since it modifies a CSSValueList that points inside
> the mutable style. Instead, the function is changed to take two
> CSSValueLists and return a new one, and the callsite is changed to
> replace the old CSSValueList with the new one in the style rather than
> modifying the old CSSValueList in-place.
>
> BUG=526586
>
> Committed: https://crrev.com/5896ec297d9240b691e7f70a239498b795531dc1
> Cr-Commit-Position: refs/heads/master@{#398151}

TBR=haraken@chromium.org,timloh@chromium.org,yukishiino@chromium.org,sashab@c...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=526586

Committed: https://crrev.com/41b2e7dad0fb637ebcf9dbd6c0e60d4bfbde48ee
Cr-Commit-Position: refs/heads/master@{#398156}
==========

[commit-bot: I haz the power, 2016-06-06 23:14:08]

Patchset 1 (id:??) landed as
https://crrev.com/41b2e7dad0fb637ebcf9dbd6c0e60d4bfbde48ee
Cr-Commit-Position: refs/heads/master@{#398156}

[haraken, 2016-06-06 23:17:29]

LGTM

[Yuki, 2016-06-07 05:18:15]

lgtm