chrome/browser/ui/views/location_bar/location_icon_view.cc - Issue 2042073002: Centered flood fill style ink drop ripples on mouse/touch points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/location_icon_view.cc

Issue 2042073002: Centered flood fill style ink drop ripples on mouse/touch points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Polished for review. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/download/download_item_view_md.cc ('K') | « chrome/browser/ui/views/location_bar/location_icon_view.h ('k') | chrome/browser/ui/views/toolbar/toolbar_action_view.cc » ('j') | ui/views/animation/ink_drop_host_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/location_icon_view.cc

diff --git a/chrome/browser/ui/views/location_bar/location_icon_view.cc b/chrome/browser/ui/views/location_bar/location_icon_view.cc

index c4c56c4b4ca851007d8f7be4dc5b28751583911c..47ca12d64165d020b2b4479370bf4fa4d89cdaff 100644

--- a/chrome/browser/ui/views/location_bar/location_icon_view.cc

+++ b/chrome/browser/ui/views/location_bar/location_icon_view.cc

@@ -109,7 +109,7 @@ void LocationIconView::OnClickOrTap(const ui::LocatedEvent& event) {

void LocationIconView::ProcessLocatedEvent(const ui::LocatedEvent& event) {

if (HitTestPoint(event.location()))

- OnActivate();

+ OnActivate(&event);

}

gfx::Size LocationIconView::GetMinimumSize() const {

@@ -131,7 +131,7 @@ SkColor LocationIconView::GetBorderColor() const {

return GetTextColor();

}

-bool LocationIconView::OnActivate() {

+bool LocationIconView::OnActivate(const ui::Event* event) {

WebContents* contents = location_bar_->GetWebContents();

if (!contents)

return false;