Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5903)

Unified Diff: chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc

Issue 2042073002: Centered flood fill style ink drop ripples on mouse/touch points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Polished for review. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
diff --git a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
index fb37a29ded5b0e86c70f417f7847342b9f9c5f02..1fe8db2fba4d6601431c4b91d26db8246265b695 100644
--- a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
+++ b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
@@ -117,7 +117,7 @@ bool IconLabelBubbleView::IsShrinking() const {
return false;
}
-bool IconLabelBubbleView::OnActivate() {
+bool IconLabelBubbleView::OnActivate(const ui::Event* event) {
return false;
}
@@ -128,13 +128,13 @@ gfx::Size IconLabelBubbleView::GetPreferredSize() const {
bool IconLabelBubbleView::OnKeyPressed(const ui::KeyEvent& event) {
if (event.key_code() == ui::VKEY_RETURN)
- return OnActivate();
+ return OnActivate(&event);
return false;
}
bool IconLabelBubbleView::OnKeyReleased(const ui::KeyEvent& event) {
if (event.key_code() == ui::VKEY_SPACE)
- return OnActivate();
+ return OnActivate(&event);
return false;
}

Powered by Google App Engine
This is Rietveld 408576698