src/IceCfg.cpp - Issue 2042063002: Created Ice::Instrumentation base class and accompanying hooks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceCfg.cpp

Issue 2042063002: Created Ice::Instrumentation base class and accompanying hooks. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Added minimum build checks, fixed other issues. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceCfg.cpp

diff --git a/src/IceCfg.cpp b/src/IceCfg.cpp

index 8f6a2fffaca0ecbf8d040b895458c0b33bb69895..a7595ff0e782cdd7832beb566f90e2872c08fec3 100644

--- a/src/IceCfg.cpp

+++ b/src/IceCfg.cpp

@@ -22,6 +22,7 @@

#include "IceELFObjectWriter.h"

#include "IceGlobalInits.h"

#include "IceInst.h"

+#include "IceInstrumentation.h"

#include "IceInstVarIter.h"

#include "IceLiveness.h"

#include "IceLoopAnalyzer.h"

@@ -238,6 +239,12 @@ void Cfg::translate() {

if (auto *Var64On32 = llvm::dyn_cast<Variable64On32>(Var))

Var64On32->initHiLo(this);

+ // Instrument the Cfg, e.g. with AddressSanitizer

+ if (!BuildDefs::minimal()) {

Karl 2016/06/07 14:42:40 Shouldn't these also be under a CL flag for saniti

tlively 2016/06/07 18:14:41 Done.

+ getContext()->instrumentFunc(this);

+ dump("Instrumented CFG");

+ }

// The set of translation passes and their order are determined by the

// target.

getTarget()->translate();

« no previous file with comments | « Makefile.standalone ('k') | src/IceClFlags.def » ('j') | src/IceCompileServer.cpp » ('J')