Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: src/IceCompileServer.cpp

Issue 2042063002: Created Ice::Instrumentation base class and accompanying hooks. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceCompileServer.cpp
diff --git a/src/IceCompileServer.cpp b/src/IceCompileServer.cpp
index adb41025dfb1f3d646fae2b5b95f3a58f00d7826..a5df3aa1aa8b017f45c681b438ea249453bda1b1 100644
--- a/src/IceCompileServer.cpp
+++ b/src/IceCompileServer.cpp
@@ -241,6 +241,11 @@ void CLCompileServer::run() {
}
Ctx.reset(new GlobalContext(Ls.get(), Os.get(), Ls.get(), ELFStr.get()));
+
+ // TODO(tlively): Make this instantiate an instrumentation subclass
Karl 2016/06/06 22:27:02 Conditionalize on BuildDefs.minimal()
tlively 2016/06/07 00:43:05 Done.
+ if (getFlags().getSanitizeAddresses())
+ Ctx->setInstrumentation(new Instrumentation(Ctx.get()));
+
if (getFlags().getNumTranslationThreads() != 0) {
std::thread CompileThread([this, &Flags, &InputStream]() {
Ctx->initParserThread();

Powered by Google App Engine
This is Rietveld 408576698