Created Ice::Instrumentation base class and accompanying hooks.

src/IceCompileServer.cpp

 //===- subzero/src/IceCompileServer.cpp - Compile server ------------------===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 223 matching lines @@
     Err.print(Flags.getAppName().c_str(), *Ls);
     return transferErrorCode(getReturnValue(Ice::EC_Bitcode));
   }
 
   if (Flags.getGenerateBuildAtts()) {
     dumpBuildAttributes(*Os.get());
     return transferErrorCode(getReturnValue(Ice::EC_None));
   }
 
   Ctx.reset(new GlobalContext(Ls.get(), Os.get(), Ls.get(), ELFStr.get()));
+
+  // TODO(tlively): Make this instantiate an instrumentation subclass
+  if (!BuildDefs::minimal() && getFlags().getSanitizeAddresses()) {
+    std::unique_ptr<Instrumentation> Instr(new Instrumentation(Ctx.get()));
+    Ctx->setInstrumentation(std::move(Instr));

[Karl, 2016/06/07 14:42:40]

Out of curiosity, could this be simplified to:

  Ctx->setInstrumentation(new Instrumentation(Ctx.get());

[tlively, 2016/06/07 18:14:41]

I just tried this and a couple variations but the compiler didn't like them.

+  }
+
   if (getFlags().getNumTranslationThreads() != 0) {
     std::thread CompileThread([this, &Flags, &InputStream]() {
       Ctx->initParserThread();
       getCompiler().run(Flags, *Ctx.get(), std::move(InputStream));
     });
     CompileThread.join();
   } else {
     getCompiler().run(Flags, *Ctx.get(), std::move(InputStream));
   }
   transferErrorCode(
       getReturnValue(static_cast<ErrorCodes>(Ctx->getErrorStatus()->value())));
   Ctx->dumpConstantLookupCounts();
   Ctx->dumpStrings();
 }
 
 } // end of namespace Ice