third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/not-opener.html - Issue 2042043002: Silencing console messages during some layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/not-opener.html

Issue 2042043002: Silencing console messages during some layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@replicate-can-open-windows

Patch Set: Added verification of # of opened windows at the end of not-opener test. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/FlagExpectations/site-per-process ('k') | third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/not-opener-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/not-opener.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/not-opener.html b/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/not-opener.html

index bdc9c6984c6a6da4cda2f4a18ee974620ff7b150..ef8277f7e21955b84db2807faa068e78f156f370 100644

--- a/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/not-opener.html

+++ b/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/not-opener.html

@@ -3,6 +3,7 @@

if (window.testRunner) {

testRunner.dumpAsText();

+ testRunner.setDumpConsoleMessages(false);

testRunner.waitUntilDone();

testRunner.setCanOpenWindows();

}

@@ -23,6 +24,7 @@ window.addEventListener("message", function(e) {

} else if (e.data == "pass") {

target.document.body.innerHTML = "Should have navigated this window. It should be still be same-origin.";

log("PASS");

+ log("There are currently " + testRunner.windowCount() + " windows opened.");

target.close();

helper.postMessage("cleanup", "*");

} else if (e.data == "done") {