components/password_manager/core/browser/password_ui_utils.h - Issue 2042033003: Displaying human-readable Android credentials on Android OS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_ui_utils.h

Issue 2042033003: Displaying human-readable Android credentials on Android OS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added unit test for SplitByDotAndReverse, addressed style issues. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/password_ui_view_android.cc ('K') | « chrome/browser/ui/passwords/password_manager_presenter.cc ('k') | components/password_manager/core/browser/password_ui_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_ui_utils.h

diff --git a/components/password_manager/core/browser/password_ui_utils.h b/components/password_manager/core/browser/password_ui_utils.h

index e876af2811af29243d2c75dac6b0994422d54d57..1ea79b9a024abeccefc1c7187b685b4d0539ad33 100644

--- a/components/password_manager/core/browser/password_ui_utils.h

+++ b/components/password_manager/core/browser/password_ui_utils.h

@@ -9,6 +9,8 @@

#include <string>

+#include "base/strings/string_piece.h"

#include "url/gurl.h"

namespace autofill {

@@ -17,6 +19,11 @@ struct PasswordForm;

namespace password_manager {

+extern const int kAndroidAppSchemeAndDelimiterLength; // Length of 'android://'

+// Reverses order of subdomains in hostname.

+std::string SplitByDotAndReverse(base::StringPiece host);

// Returns a string suitable for security display to the user (just like

// |FormatUrlForSecurityDisplay| with OMIT_HTTP_AND_HTTPS) based on origin of

// |password_form| and without prefixes "m.", "mobile." or "www.". Also