Displaying human-readable Android credentials on Android OS.

components/password_manager/core/browser/password_ui_utils.h

Index: components/password_manager/core/browser/password_ui_utils.h
diff --git a/components/password_manager/core/browser/password_ui_utils.h b/components/password_manager/core/browser/password_ui_utils.h
index e876af2811af29243d2c75dac6b0994422d54d57..69c2850296ad15276408038ed6800e7efc3cbd42 100644
--- a/components/password_manager/core/browser/password_ui_utils.h
+++ b/components/password_manager/core/browser/password_ui_utils.h
@@ -9,14 +9,23 @@
 
 #include <string>
 
+#include "base/strings/string_piece.h"
+
 #include "url/gurl.h"
 
+using base::StringPiece;

[vabr (Chromium), 2016/06/08 09:04:05]

nit: Please do not use the "using" directive in header files. Those may be
included in many other files and cause naming conflicts. Please use the full
type name with its namespace in the header, and only use "using" in the .cc file
if the type name is used often enough and the namespace prefix is awkwardly
long. (This is not necessarily the case here.)

[dozsa, 2016/06/08 11:22:30]

Done.

+
 namespace autofill {
 struct PasswordForm;
 }
 
 namespace password_manager {
 
+extern const int kAndroidAppSchemeAndDelimiterLength;  // Length of 'android://'
+
+// Reverses order of subdomains in hostname

[vabr (Chromium), 2016/06/08 09:04:05]

nit: Don't forget the full-stop (.) at the end of the sentence.

+std::string SplitByDotAndReverse(StringPiece host);
+
 // Returns a string suitable for security display to the user (just like
 // |FormatUrlForSecurityDisplay| with OMIT_HTTP_AND_HTTPS) based on origin of
 // |password_form| and without prefixes "m.", "mobile." or "www.". Also