Displaying human-readable Android credentials on Android OS.

components/password_manager/core/browser/password_ui_utils.cc

Index: components/password_manager/core/browser/password_ui_utils.cc
diff --git a/components/password_manager/core/browser/password_ui_utils.cc b/components/password_manager/core/browser/password_ui_utils.cc
index 239213192858277e3234f5713582700c7099205d..c9579265e54a97e4f0a1c594830e9ec4ede21457 100644
--- a/components/password_manager/core/browser/password_ui_utils.cc
+++ b/components/password_manager/core/browser/password_ui_utils.cc
@@ -4,8 +4,11 @@
 
 #include "components/password_manager/core/browser/password_ui_utils.h"
 
+#include <algorithm>
 #include <string>
 
+#include "base/strings/string_piece.h"
+#include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/common/password_form.h"
@@ -21,6 +24,16 @@ const char* const kRemovedPrefixes[] = {"m.", "mobile.", "www."};
 
 }  // namespace
 
+const int kAndroidAppSchemeAndDelimiterLength = 10;  // Length of 'android://'.

[Bernhard Bauer, 2016/06/13 09:34:59]

Actually, could you define this as sizeof("android://")? :) The compiler should
be able to figure out the length of the string without putting the actual bytes
into the object file.

[dozsa, 2016/06/13 12:36:18]

Done.

+
+// Reverse order of subdomains in hostname.

[vabr (Chromium), 2016/06/13 09:45:21]

nit: No need to copy the comment in the .cc, when it already is in the header.

[dozsa, 2016/06/13 12:36:17]

Done.

+std::string SplitByDotAndReverse(base::StringPiece host) {
+  std::vector<std::string> parts =
+      base::SplitString(host, ".", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
+  std::reverse(parts.begin(), parts.end());
+  return base::JoinString(parts, ".");
+}
+
 std::string GetShownOriginAndLinkUrl(
     const autofill::PasswordForm& password_form,
     bool* is_android_uri,