Displaying human-readable Android credentials on Android OS.

chrome/browser/ui/passwords/password_manager_presenter.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/passwords/password_manager_presenter.h"
 
+#include <algorithm>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/memory/ptr_util.h"
 #include "base/metrics/user_metrics_action.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 27 matching lines @@
 #include "chrome/browser/password_manager/password_manager_util_win.h"
 #elif defined(OS_MACOSX)
 #include "chrome/browser/password_manager/password_manager_util_mac.h"
 #endif
 
 using base::StringPiece;
 using password_manager::PasswordStore;
 
 namespace {
 
-const int kAndroidAppSchemeAndDelimiterLength = 10;  // Length of 'android://'.
-
 const char kSortKeyPartsSeparator = ' ';
 
-// Reverse order of subdomains in hostname.
-std::string SplitByDotAndReverse(StringPiece host) {
-  std::vector<std::string> parts =
-      base::SplitString(host, ".", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
-  std::reverse(parts.begin(), parts.end());
-  return base::JoinString(parts, ".");
-}
-
 // Helper function that returns the type of the entry (non-Android credentials,
 // Android w/ affiliated web realm (i.e. clickable) or w/o web realm).
 std::string GetEntryTypeCode(bool is_android_uri, bool is_clickable) {
   if (!is_android_uri)
     return "0";
   if (is_clickable)
     return "1";
   return "2";
 }
 
 // Creates key for sorting password or password exception entries.
 // The key is eTLD+1 followed by subdomains
 // (e.g. secure.accounts.example.com => example.com.accounts.secure).
 // If |entry_type == SAVED|, username, password and federation are appended to
 // the key. The entry type code (non-Android, Android w/ or w/o affiliated web
 // realm) is also appended to the key.
 std::string CreateSortKey(const autofill::PasswordForm& form,
                           PasswordEntryType entry_type) {
   bool is_android_uri = false;
   bool is_clickable = false;
   GURL link_url;
   std::string origin = password_manager::GetShownOriginAndLinkUrl(
       form, &is_android_uri, &link_url, &is_clickable);
 
   if (!is_clickable) {  // e.g. android://com.example.r => r.example.com.
-    origin = SplitByDotAndReverse(
-        StringPiece(&origin[kAndroidAppSchemeAndDelimiterLength],
-                    origin.length() - kAndroidAppSchemeAndDelimiterLength));
+    origin = password_manager::SplitByDotAndReverse(
+        StringPiece(
+            &origin[password_manager::kAndroidAppSchemeAndDelimiterLength],

[Bernhard Bauer, 2016/06/13 09:34:59]

Instead of exposing this constant, I think it would be better to expose a
function that does this, and keep the constant an implementation detail of that
function.

[dozsa, 2016/06/13 12:36:17]

Done.

+                    origin.length() -
+                    password_manager::kAndroidAppSchemeAndDelimiterLength));
   }
 
   std::string site_name =
       net::registry_controlled_domains::GetDomainAndRegistry(
           origin, net::registry_controlled_domains::INCLUDE_PRIVATE_REGISTRIES);
   if (site_name.empty())  // e.g. localhost.
     site_name = origin;
   std::string key =
-      site_name + SplitByDotAndReverse(StringPiece(
+      site_name + password_manager::SplitByDotAndReverse(StringPiece(
                       &origin[0], origin.length() - site_name.length()));
 
   if (entry_type == PasswordEntryType::SAVED) {
     key = key + kSortKeyPartsSeparator +
           base::UTF16ToUTF8(form.username_value) + kSortKeyPartsSeparator +
           base::UTF16ToUTF8(form.password_value);
     if (!form.federation_origin.unique())
       key = key + kSortKeyPartsSeparator + form.federation_origin.host();
   }
 
@@ skipping 285 matching lines @@
 
 void PasswordManagerPresenter::PasswordExceptionListPopulater::
     OnGetPasswordStoreResults(ScopedVector<autofill::PasswordForm> results) {
   page_->password_exception_list_ =
       password_manager_util::ConvertScopedVector(std::move(results));
   page_->SortEntriesAndHideDuplicates(&page_->password_exception_list_,
                                       &page_->password_exception_duplicates_,
                                       PasswordEntryType::BLACKLISTED);
   page_->SetPasswordExceptionList();
 }