src/runtime/runtime-typedarray.cc - Issue 2042013003: [builtins] Properly optimize TypedArray/DataView accessors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-typedarray.cc

Issue 2042013003: [builtins] Properly optimize TypedArray/DataView accessors. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address Yang's comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-typedarray.cc

diff --git a/src/runtime/runtime-typedarray.cc b/src/runtime/runtime-typedarray.cc

index 14b120747afa235c3260358e16904f517d375bf0..272bcda9f19368eedb6ca950883fda0ed422a02a 100644

--- a/src/runtime/runtime-typedarray.cc

+++ b/src/runtime/runtime-typedarray.cc

@@ -284,7 +284,6 @@ RUNTIME_FUNCTION(Runtime_TypedArrayInitializeFromArrayLike) {

BUFFER_VIEW_GETTER(ArrayBufferView, ByteLength, byte_length)

BUFFER_VIEW_GETTER(ArrayBufferView, ByteOffset, byte_offset)

BUFFER_VIEW_GETTER(TypedArray, Length, length)

-BUFFER_VIEW_GETTER(DataView, Buffer, buffer)

#undef BUFFER_VIEW_GETTER

« no previous file with comments | « src/runtime/runtime.h ('k') | no next file » | no next file with comments »